add best track index to determine which electron charge to use in `ScoutingDileptonMonitor` by mmusich · Pull Request #50474 · cms-sw/cmssw

mmusich · 2026-03-19T14:24:59Z

PR description:

This is PR is based off #50444.

Extend ScoutingDileptonMonitor to use a configurable “best track” per lepton instead of a single fixed track source.
Introduce logic to select the optimal track (e.g. best quality/fit) among available candidates.
Update invariant mass and kinematic calculatations to consistently use this chosen best track.
Improve handling of missing or invalid track references (safer fallback behavior).
Refactor code structure to separate track selection from monitoring logic.
Simplify and clean up duplicated code paths related to track access.
Update histogram filling to reflect the new best-track choice.
Adjust configuration parameters to allow flexibility in track selection.
Minor style/modernization improvements (readability, const-correctness).

Overall: more robust and physically meaningful dilepton monitoring using optimal track information.

PR validation:

scram b runtests_TestDQMOnlineClient-ngt_dqm_sourceclient
scram b runtests_TestDQMOnlineClient-scouting_dqm_sourceclient
runTheMatrix.py -l 18434.0 -t 4 -j 8

all run fine.
Using the following script, running on scouting events obtained running of the ZtoEE RAW-RECO skim of 2025 data:

#!/bin/bash -ex

LOCALPATH='/eos/cms/store/group/tsg-phase2/user/jprendi/NERD25/MoreStats/EGammas/HLT/'
echo "Input source: |${LOCALPATH}|"
LOCALFILES=$(ls -1 ${LOCALPATH} | grep Scouting)
ALL_FILES=""
for f in ${LOCALFILES[@]}; do
    ALL_FILES+="file:${LOCALPATH}/${f},"
done

# Remove the last character
ALL_FILES="${ALL_FILES%?}"
echo "Discovered files: $ALL_FILES"

cmsDriver.py step2 -s DQM:hltScoutingCollectionMonitor+hltScoutingDileptonMonitor+hltScoutingPi0Monitor \
             --conditions 160X_dataRun3_HLT_v1 \
             --datatier DQMIO \
             -n -1 \
             --eventcontent DQMIO \
             --geometry DB:Extended \
             --era Run3_2025 \
             --filein file:$ALL_FILES \
             --fileout file:step2.root \
             --nThreads 24 \
             --python_filename dqm.py \
             --no_exec

cat <<@EOF >> dqm.py
# import best track producer
from PhysicsTools.Scouting.Run3ScoutingElectronBestTrackProducer_cfi import Run3ScoutingElectronBestTrackProducer
process.run3ScoutingElectronBestTrack =  Run3ScoutingElectronBestTrackProducer.clone()
# import beamspot
from RecoVertex.BeamSpotProducer.BeamSpotOnline_cfi import onlineBeamSpotProducer as _onlineBeamSpotProducer
process.hltOnlineBeamSpot = _onlineBeamSpotProducer.clone()
process.scoutingCollectionMonitor.onlineMetaDataDigis = "hltOnlineMetaDataDigis"
process.scoutingCollectionMonitor.onlyScouting = True
process.dqmoffline_step = cms.EndPath(process.hltOnlineBeamSpot+process.hltScoutingCollectionMonitor+process.run3ScoutingElectronBestTrack+process.hltScoutingDileptonMonitor+process.hltScoutingPi0Monitor)
@EOF

cmsRun dqm.py >& dqm.log

cmsDriver.py step3 -s HARVESTING:@hltScouting \
         --conditions 160X_dataRun3_HLT_v1 \
         --data \
         --geometry DB:Extended \
         --scenario pp \
         --filetype DQM \
         --era Run3_2025 \
         -n 10000 \
         --filein file:step2.root \
         --fileout file:step3.root \
         --no_exec

cmsRun step3_HARVESTING.py >& harvesting.log

we observe a substantial increase of the Z→ee event yield.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, it will be backported to CMSSW_16_0_X for 2026 data-taking operations.

cmsbuild · 2026-03-19T14:25:27Z

cms-bot internal usage

cmsbuild · 2026-03-19T14:26:46Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50474/48613

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50474/48613/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50474/48613/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-03-19T14:32:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50474/48615

cmsbuild · 2026-03-19T14:33:06Z

A new Pull Request was created by @mmusich for master.

It involves the following packages:

DQMOffline/HLTScouting (dqm)
HLTriggerOffline/Scouting (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@missirol, @mtosi, @rociovilar this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2026-03-19T14:33:40Z

@cmsbuild, please test

cmsbuild · 2026-03-19T17:26:28Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-551595/52099/summary.html
COMMIT: 53a2494
CMSSW: CMSSW_16_1_X_2026-03-18-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50474/52099/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-551595/52099/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-551595/52099/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test Zmumuall had ERRORS

Comparison Summary

Summary:

You potentially removed 200 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 20742 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4185208
DQMHistoTests: Total failures: 3238
DQMHistoTests: Total nulls: 23
DQMHistoTests: Total successes: 4181927
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 31.630000000000003 KiB( 52 files compared)
DQMHistoSizes: changed ( 18434.0,... ): 8.677 KiB HLT/ScoutingOffline
DQMHistoSizes: changed ( 2024.0000001,... ): -0.381 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 2024.0000001 ): 0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0010001 ): -0.020 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0020001 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0040001 ): -0.062 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0050001 ): 0.035 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0060001 ): 0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0070001 ): 0.004 KiB JetMET/SUSYDQM
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: found differences in 3 / 51 workflows

mmusich · 2026-03-19T17:40:16Z

@cmsbuild, please test

let's try in the new IB

cmsbuild · 2026-03-19T19:42:08Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-551595/52102/summary.html
COMMIT: 53a2494
CMSSW: CMSSW_16_1_X_2026-03-19-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50474/52102/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4185284
DQMHistoTests: Total failures: 67
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4185197
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 8.368 KiB( 52 files compared)
DQMHistoSizes: changed ( 18434.0,... ): 2.092 KiB HLT/ScoutingOffline
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

…utingDileptonMonitor

cmsbuild · 2026-03-20T08:56:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50474/48625

cmsbuild · 2026-03-20T08:57:00Z

Pull request #50474 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

mmusich · 2026-03-20T08:59:40Z

test parameters:

addpkg = DQM/Integration

mmusich · 2026-03-20T08:59:53Z

@cmsbuild, please test

cmsbuild · 2026-03-20T10:56:22Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-551595/52109/summary.html
COMMIT: bf0b30c
CMSSW: CMSSW_16_1_X_2026-03-19-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50474/52109/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 13 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4185284
DQMHistoTests: Total failures: 55
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4185209
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 8.368 KiB( 52 files compared)
DQMHistoSizes: changed ( 18434.0,... ): 2.092 KiB HLT/ScoutingOffline
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

gabrielmscampos · 2026-03-20T13:03:19Z

+dqm

cmsbuild · 2026-03-20T13:03:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

ftenchini · 2026-03-23T16:08:46Z

+1

cmsbuild added this to the CMSSW_16_1_X milestone Mar 19, 2026

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 19, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 19, 2026

mmusich force-pushed the ScoutingDileptonMonitor_bestTrack branch from 34b0917 to 53a2494 Compare March 19, 2026 14:30

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 19, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 19, 2026

cmsbuild added tests-started and removed tests-pending labels Mar 19, 2026

cmsbuild added tests-rejected and removed tests-started labels Mar 19, 2026

cmsbuild added tests-started and removed tests-rejected labels Mar 19, 2026

cmsbuild added tests-approved and removed tests-started labels Mar 19, 2026

gabrielmscampos reviewed Mar 20, 2026

View reviewed changes

Comment thread HLTriggerOffline/Scouting/plugins/ScoutingDileptonMonitor.cc

add best track index to determine which electron charge to use in Sco…

bf0b30c

…utingDileptonMonitor

mmusich force-pushed the ScoutingDileptonMonitor_bestTrack branch from 53a2494 to bf0b30c Compare March 20, 2026 08:54

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Mar 20, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 20, 2026

cmsbuild added tests-started and removed tests-pending labels Mar 20, 2026

cmsbuild added tests-approved and removed tests-started labels Mar 20, 2026

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Mar 20, 2026

mmusich mentioned this pull request Mar 23, 2026

[16.0.X] add best track index to determine which electron charge to use in ScoutingDileptonMonitor #50494

Merged

cmsbuild added orp-approved and removed orp-pending labels Mar 23, 2026

cmsbuild merged commit cf5b3a0 into cms-sw:master Mar 23, 2026
11 checks passed

mmusich deleted the ScoutingDileptonMonitor_bestTrack branch March 23, 2026 16:09

Uh oh!

Conversation

mmusich commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Mar 19, 2026

Uh oh!

cmsbuild commented Mar 19, 2026

Uh oh!

cmsbuild commented Mar 19, 2026

Uh oh!

mmusich commented Mar 19, 2026

Uh oh!

cmsbuild commented Mar 19, 2026

Failed Unit Tests

Comparison Summary

Uh oh!

mmusich commented Mar 19, 2026

Uh oh!

cmsbuild commented Mar 19, 2026

Comparison Summary

Uh oh!

Uh oh!

cmsbuild commented Mar 20, 2026

Uh oh!

cmsbuild commented Mar 20, 2026

Uh oh!

mmusich commented Mar 20, 2026

Uh oh!

mmusich commented Mar 20, 2026

Uh oh!

cmsbuild commented Mar 20, 2026

Comparison Summary

Uh oh!

gabrielmscampos commented Mar 20, 2026

Uh oh!

cmsbuild commented Mar 20, 2026

Uh oh!

ftenchini commented Mar 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mmusich commented Mar 19, 2026 •

edited

Loading

cmsbuild commented Mar 19, 2026 •

edited

Loading