Skip to content

Scouting DQM: add best-track and shower-shape monitoring for scouting electrons [16.0.X]#50457

Merged
cmsbuild merged 2 commits into
cms-sw:CMSSW_16_0_Xfrom
sakura-ngt:improveScoutingEleMonitoring
Mar 24, 2026
Merged

Scouting DQM: add best-track and shower-shape monitoring for scouting electrons [16.0.X]#50457
cmsbuild merged 2 commits into
cms-sw:CMSSW_16_0_Xfrom
sakura-ngt:improveScoutingEleMonitoring

Conversation

@sakura-ngt

@sakura-ngt sakura-ngt commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

backport of #50444

PR description:

This PR extends ScoutingCollectionMonitor with additional electron and photon monitoring. It adds calorimeter variables (nClusters, nCrystals, rechitZeroSuppression), electron track multiplicity, and best-track observables via edm::ValueMaps from run3ScoutingElectronBestTrack.

New histograms are booked and filled using edm::Ref access, skipping electrons without valid tracks. The required ValueMap inputs are added to the configuration.

The run3ScoutingElectronBestTrack producer is included in both online and offline DQM sequences.

PR validation:

These commands run fine:

scram b runtests_ngt_dqm_sourceclient
scram b runtests_scouting_dqm_sourceclient

as well as:

runTheMatrix.py -l 18434.0 -t 4 -j 8

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #50444 to the 2026 data-taking release.

@cmsbuild

cmsbuild commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @sakura-ngt for CMSSW_16_0_X.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • DQM/Integration (dqm)
  • DQMOffline/HLTScouting (dqm)

@Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @missirol, @mmusich, @mtosi, @rociovilar, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

cmsbuild commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@sakura-ngt
sakura-ngt force-pushed the improveScoutingEleMonitoring branch from 1455ffd to 937f5aa Compare March 17, 2026 19:53
@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #50457 was updated. @Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please check and sign again.

@mmusich

mmusich commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild, please test

@sakura-ngt

Copy link
Copy Markdown
Contributor Author

type ngt

@cmsbuild cmsbuild added the ngt label Mar 18, 2026
@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7b6a7/52065/summary.html
COMMIT: 937f5aa
CMSSW: CMSSW_16_0_X_2026-03-17-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50457/52065/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4166533
  • DQMHistoTests: Total failures: 78
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4166435
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 26.34 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 18434.0,... ): 6.585 KiB HLT/ScoutingOffline
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@mmusich

mmusich commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

+hlt

@gabrielmscampos

Copy link
Copy Markdown
Member

+dqm

  • Tests passed on DQM P5 playback environment

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild

Copy link
Copy Markdown
Contributor

REMINDER @sextonkennedy, @mandrenguyen, @ftenchini: This PR was tested with #50494, please check if they should be merged together

@ftenchini

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit b78e2c0 into cms-sw:CMSSW_16_0_X Mar 24, 2026
8 checks passed
@mmusich
mmusich deleted the improveScoutingEleMonitoring branch March 24, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants