Skip to content

Update MPI Test software#49942

Merged
cmsbuild merged 2 commits into
cms-sw:masterfrom
ghyls:abeer-tests
Jun 29, 2026
Merged

Update MPI Test software#49942
cmsbuild merged 2 commits into
cms-sw:masterfrom
ghyls:abeer-tests

Conversation

@ghyls

@ghyls ghyls commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

PR description:

This PR adds a commit on top of #42594, with the aim of preparing the code in #42594 to get merged. The changes proposed by #42594 are:

PR validation:

The test introduced by this PR passes.

@cmsbuild

cmsbuild commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49942/47703

  • Found files with invalid states:

    • HeterogeneousCore/MPICore/test/masterMPI_process.h:
    • HeterogeneousCore/MPICore/test/MPI_mainTest_Performance.cc:
    • HeterogeneousCore/MPICore/test/processInterface.h:
    • HeterogeneousCore/MPICore/test/workerMPI_process.h:
  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @ghyls for master.

It involves the following packages:

  • HeterogeneousCore/MPICore (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

cmsbuild commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

Milestone for this pull request has been moved to CMSSW_17_0_X. Please open a backport if it should also go in to CMSSW_16_1_X.

@cmsbuild

cmsbuild commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Milestone for this pull request has been moved to CMSSW_20_0_X. Please open a backport if it should also go in to CMSSW_17_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_17_0_X, CMSSW_20_0_X Jun 5, 2026
@cmsbuild

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49942/49991

@ghyls

ghyls commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @fwyzard.
The two clang warnings are fixed.

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #49942 was updated. @cmsbuild, @fwyzard, @makortel can you please check and sign again.

@fwyzard

fwyzard commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f96c4/54350/summary.html
COMMIT: e7dd95a
CMSSW: CMSSW_20_1_X_2026-06-28-0000/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49942/54350/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3414477
  • DQMHistoTests: Total failures: 22
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3414437
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@fwyzard

fwyzard commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

+heterogeneous

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit 815a9fd into cms-sw:master Jun 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants