Phase2 Single_Tau_Trigger Path Added by Chihwan-An · Pull Request #49637 · cms-sw/cmssw

Chihwan-An · 2025-12-16T06:35:32Z

Added Single Tau Trigger path for Phase2 , worked with Tau HLT Phase2 development group.

It was tested in miniAOD in CMSSW_15_1_0_pre4 and NanoAOD in CMSSW_16_0_0_pre2 , with Z'to tautau samples.

Trigger Efficiency had 48.7% .

Phase2 Single_Tau_Trigger Path Added #49569 was submitted before.
- MinEta for HLT1PFTau EDFilters has a default value of -1.0, which the config understands it as being -2.1.
Slides are not shared with TSG group yet , shared with Tau HLT phase2 group .

cmsbuild · 2025-12-16T06:36:02Z

cms-bot internal usage

cmsbuild · 2025-12-16T06:37:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/47177

Found files with invalid states:
- HLTrigger/Configuration/python/HLT_75e33/modules/hltPreLooseDeepTauPFTauHPS150L2NNeta2p1_cfi.py:
  - Added: cfc92f4
  - Deleted: 57b17b8

cmsbuild · 2025-12-16T06:37:46Z

A new Pull Request was created by @Chihwan-An for master.

It involves the following packages:

HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2025-12-16T07:38:38Z

please test

cmsbuild · 2025-12-16T09:16:51Z

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3976a9/49993/summary.html
COMMIT: 57b17b8
CMSSW: CMSSW_16_0_X_2025-12-15-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49637/49993/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 15 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4280229
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4280200
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

mmusich · 2025-12-16T09:17:47Z

test parameters:

enable = hlt_p2_integration, hlt_p2_timing
workflows = ph2_hlt

mmusich · 2025-12-16T09:17:56Z

@cmsbuild, please test

mmusich · 2025-12-16T17:05:01Z

Hi @Chihwan-An,
the timing tests are not completed, but I see that this PR is already failing one of the relval tests: 34434.758_TTbar_14TeV+Run4D121_HLT75e33TimingTiclBarrel, see log.
Can you try to reproduce locally by executing runTheMatrix.py -l 34434.758 locally and fix the configuration? From the exception message it looks like it should be fixable by re-ordering the modules scheduled in the new path HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1

mmusich · 2025-12-16T17:13:45Z

hold

Slides are not shared with TSG group yet , shared with Tau HLT phase2 group .
the new path should be discussed first in a HLT upgrade meeting @rovere @VourMa FYI

cmsbuild · 2025-12-16T17:14:04Z

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

mmusich · 2025-12-17T08:50:32Z

@smuzaffar the hlt phase2 timing tests doesn't seem to start, can you check what is the problem with it?

smuzaffar · 2025-12-17T09:10:27Z

@mmusich , I see that job started an hour ago (https://cmssdt.cern.ch/jenkins/job/ib-run-pr-hlt_p2_timing/241/console) . It should finish soon

cmsbuild · 2025-12-17T09:10:38Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3976a9/49995/summary.html
COMMIT: 57b17b8
CMSSW: CMSSW_16_0_X_2025-12-15-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49637/49995/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Failed RelVals

34434.758

----- Begin Fatal Exception 16-Dec-2025 11:15:10 CET-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
Dependent module later on Path
  module 'hltParticleFlowRecHitECALUnseeded' depends on 'hltEcalRecHit' which is later on path HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1
----- End Fatal Exception -------------------------------------------------

mmusich · 2026-06-18T06:39:50Z

@cmsbuild, please test

to get comparisons with the baseline

cmsbuild · 2026-06-18T09:05:00Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3976a9/54054/summary.html
COMMIT: d65a25a
CMSSW: CMSSW_20_1_X_2026-06-17-2300/el9_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49637/54054/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 17 differences found in the comparisons
DQMHistoTests: Total files compared: 59
DQMHistoTests: Total histograms compared: 3872067
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3872049
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 58 files compared)
Checked 249 log files, 203 edm output root files, 59 DQM output files

mmusich · 2026-06-19T11:58:19Z

Summary of the tests:

Resources usage

Basically unvaried: Summary table

Timing

There is an increase in timing of

+2.95%

link

largely driven by the Tau and HGCal categories:

Physics

Physics-wise I am not able to see any discernible difference in the tested workflows. @elenavernazza should I expect to see something due to the new path in the newly introduced Tau validation?

mmusich · 2026-06-19T11:59:57Z

+hlt

for Phase2 Single_Tau_Trigger Path Added #49637 @ d65a25a
technical implementation OK, with the large caveat of the robust timing penalty, see Phase2 Single_Tau_Trigger Path Added #49637 (comment)

mmusich · 2026-06-19T12:00:41Z

@rovere @VourMa I will keep this PR on hold, until I am explicitly given green-light about it (the current situation is not clear to me)

elenavernazza · 2026-06-19T12:08:34Z

Hi @mmusich
Not really, the newly introduced tau validation only provides object-based plots.
The path-based validation is currently performed using standalone repositories; however, after recent discussion within the TAU POG, we have decided to start developing a unified path-based validation within the centralised CMSSW VALIDATION step. The development will also cover the SingleTau path, but is not yet ready for integration.

mmusich · 2026-06-19T12:10:01Z

Not really, the newly introduced tau validation only provides object-based plots.

does it mean that there is no additional (within statistics) increase in the per-tau efficiency due to this path?

elenavernazza · 2026-06-19T12:14:04Z

The addition of this single-tau path inside the Phase-II HLT menu is not modifying in any way the HLTPFTauHPS or HLTHPSDeepTauPFTauSequence collections, which are the ones considered for the object-based validation.
So correct, no increase in the per-tau efficiency.

mmusich · 2026-06-19T12:17:17Z

is not modifying in any way the HLTPFTauHPS or HLTHPSDeepTauPFTauSequence collections, which are the ones considered for the object-based validation.

OK, so the per-object validation disregards the path that actually reconstructed them, got it.

VourMa · 2026-06-19T12:25:29Z

Physics-wise I am not able to see any discernible difference in the tested workflows.

What about adding the path in the HLT standalone validation tool? Hopefully that will allow us to monitor the new path, and the implementation of the ditau paths can serve as a useful example?

elenavernazza · 2026-06-19T12:29:20Z

Hi @VourMa I think it's a good idea! I'll follow up with the developers for the technical implementation (if you have instructions at hand it would be super useful)

mmusich · 2026-06-19T12:31:42Z

I'll follow up with the developers for the technical implementation (if you have instructions at hand it would be super useful)

Since in principle we run that also in the cmssw relval jobs now, is it just a matter of adding the path here:

cmssw/Validation/HLTrigger/python/HLTGenValidation_cff.py

Lines 562 to 564 in 03fbc40

    
           hltPathsToCheck = cms.vstring( 
        
               'HLT_DoubleMediumChargedIsoPFTauHPS40_eta2p1', 
        
               'HLT_DoubleMediumDeepTauPFTauHPS35_eta2p1'

?

VourMa · 2026-06-19T12:33:27Z

I'll follow up with the developers for the technical implementation (if you have instructions at hand it would be super useful)

Since in principle we run that also in the cmssw relval jobs now, is it just a matter of adding the path here:

cmssw/Validation/HLTrigger/python/HLTGenValidation_cff.py

Lines 562 to 564 in 03fbc40

hltPathsToCheck = cms.vstring(

'HLT_DoubleMediumChargedIsoPFTauHPS40_eta2p1',

'HLT_DoubleMediumDeepTauPFTauHPS35_eta2p1'

?

It should be. The PR that implemented this (by @Sam-Harper) and may be helpful is here: #47252

mmusich · 2026-06-19T12:39:07Z

@Chihwan-An can you please implement this #49637 (comment) in your PR to see if we actually see changes in the physics validation?

cmsbuild · 2026-06-22T04:19:48Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/49873

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/49873/cms-checkout-topic.log

mmusich · 2026-06-22T06:06:49Z

@Chihwan-An this branch has conflicts that must be resolved.

cmsbuild · 2026-06-22T06:26:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/49874

There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/HLT_75e33_cff.py modified in PR(s): [NGT] DNN for HP Pixel track selection #51042, Track Purity DNN for Phase-2 HLT #51084
- File HLTrigger/Configuration/python/HLT_75e33_timing_cff.py modified in PR(s): [NGT] DNN for HP Pixel track selection #51042, Track Purity DNN for Phase-2 HLT #51084

cmsbuild · 2026-06-22T06:26:46Z

Pull request #49637 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @rseidita can you please check and sign again.

mmusich · 2026-06-22T06:27:29Z

@Chihwan-An please squash the commits (i.e. no merge commits)

- Add HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1 path - Add hltHpsPFTau150LooseTauWPDeepTau module - Update HLT configuration and timing - Add SingleTau trigger validation in HLTGenValidation

cmsbuild · 2026-06-22T08:09:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/49876

There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/HLT_75e33_cff.py modified in PR(s): [NGT] DNN for HP Pixel track selection #51042, Track Purity DNN for Phase-2 HLT #51084
- File HLTrigger/Configuration/python/HLT_75e33_timing_cff.py modified in PR(s): [NGT] DNN for HP Pixel track selection #51042, Track Purity DNN for Phase-2 HLT #51084

cmsbuild · 2026-06-22T08:09:33Z

Pull request #49637 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @rseidita can you please check and sign again.

mmusich · 2026-06-22T08:11:25Z

@cmsbuild, please test

cmsbuild · 2026-06-22T10:19:43Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3976a9/54170/summary.html
COMMIT: 9ce5905
CMSSW: CMSSW_20_1_X_2026-06-21-2300/el9_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49637/54170/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 17 differences found in the comparisons
DQMHistoTests: Total files compared: 59
DQMHistoTests: Total histograms compared: 3872067
DQMHistoTests: Total failures: 7866
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3864183
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 146.048 KiB( 58 files compared)
DQMHistoSizes: changed ( 34434.0,... ): 1.786 KiB HLTGenVal/tauHAD__HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1__hltHpsPFTau150LooseTauWPDeepTau__2Dvspteta
DQMHistoSizes: changed ( 34434.0,... ): 1.774 KiB HLTGenVal/tauHAD__HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1__hltL1SingleNNTau150__2Dvspteta
DQMHistoSizes: changed ( 34434.0,... ): 1.771 KiB HLTGenVal/tauHAD__HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1__hltHpsPFTauTrack__2Dvspteta
DQMHistoSizes: changed ( 34434.0,... ): 1.761 KiB HLTGenVal/tauHAD__HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1__GEN__2Dvspt__eta
DQMHistoSizes: changed ( 34434.0,... ): 0.211 KiB HLTGenVal/tauHAD__HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1__hltHpsPFTau150LooseTauWPDeepTau__vspt
DQMHistoSizes: changed ( 34434.0,... ): 0.199 KiB HLTGenVal/tauHAD__HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1__hltL1SingleNNTau150__vspt
DQMHistoSizes: changed ( 34434.0,... ): 0.196 KiB HLTGenVal/tauHAD__HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1__hltHpsPFTauTrack__vspt
DQMHistoSizes: changed ( 34434.0,... ): 0.184 KiB HLTGenVal/tauHAD__HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1__GEN__vspt
DQMHistoSizes: changed ( 34434.0,... ): 0.157 KiB HLTGenVal/tauHAD__HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1__hltHpsPFTau150LooseTauWPDeepTau__vseta
DQMHistoSizes: changed ( 34434.0,... ): 0.146 KiB HLTGenVal/tauHAD__HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1__hltL1SingleNNTau150__vseta
DQMHistoSizes: changed ( 34434.0 ): ...
Checked 249 log files, 203 edm output root files, 59 DQM output files

mmusich · 2026-07-11T18:57:30Z

unhold

gabrielmscampos · 2026-07-13T07:22:59Z

+dqm

cmsbuild · 2026-07-13T07:23:25Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-07-14T03:55:12Z

+1

cmsbuild added this to the CMSSW_16_0_X milestone Dec 16, 2025

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Dec 16, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 16, 2025

cmsbuild added tests-started and removed tests-pending labels Dec 16, 2025

cmsbuild added tests-approved and removed tests-started labels Dec 16, 2025

cmsbuild added tests-started and removed tests-approved labels Dec 16, 2025

cmsbuild added the hold label Dec 16, 2025

cmsbuild added tests-rejected and removed tests-started labels Dec 17, 2025

cmsbuild mentioned this pull request Jun 18, 2026

Clean-up of Phase-2 HLT menus #51260

Merged

Add Phase2 Single Tau HLT and Validation Tool

9ce5905

- Add HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1 path - Add hltHpsPFTau150LooseTauWPDeepTau module - Update HLT configuration and timing - Add SingleTau trigger validation in HLTGenValidation

cmsbuild mentioned this pull request Jul 6, 2026

Add scouting to Phase-2 HLT menu #51424

Merged

Uh oh!

Conversation

Chihwan-An commented Dec 16, 2025

Uh oh!

cmsbuild commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Dec 16, 2025

Uh oh!

cmsbuild commented Dec 16, 2025

Uh oh!

Martin-Grunewald commented Dec 16, 2025

Uh oh!

cmsbuild commented Dec 16, 2025

Comparison Summary

Uh oh!

mmusich commented Dec 16, 2025

Uh oh!

mmusich commented Dec 16, 2025

Uh oh!

mmusich commented Dec 16, 2025

Uh oh!

mmusich commented Dec 16, 2025

Uh oh!

cmsbuild commented Dec 16, 2025

Uh oh!

mmusich commented Dec 17, 2025

Uh oh!

smuzaffar commented Dec 17, 2025

Uh oh!

cmsbuild commented Dec 17, 2025

Failed RelVals

Uh oh!

mmusich commented Jun 18, 2026

Uh oh!

cmsbuild commented Jun 18, 2026

Comparison Summary

Uh oh!

mmusich commented Jun 19, 2026

Resources usage

Timing

+2.95%

Physics

Uh oh!

mmusich commented Jun 19, 2026

Uh oh!

mmusich commented Jun 19, 2026

Uh oh!

elenavernazza commented Jun 19, 2026

Uh oh!

mmusich commented Jun 19, 2026

Uh oh!

elenavernazza commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmusich commented Jun 19, 2026

Uh oh!

VourMa commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elenavernazza commented Jun 19, 2026

Uh oh!

mmusich commented Jun 19, 2026

Uh oh!

VourMa commented Jun 19, 2026

Uh oh!

mmusich commented Jun 19, 2026

Uh oh!

cmsbuild commented Jun 22, 2026

Uh oh!

mmusich commented Jun 22, 2026

Uh oh!

cmsbuild commented Jun 22, 2026

Uh oh!

cmsbuild commented Jun 22, 2026

Uh oh!

mmusich commented Jun 22, 2026

Uh oh!

cmsbuild commented Jun 22, 2026

Uh oh!

cmsbuild commented Dec 16, 2025 •

edited

Loading

elenavernazza commented Jun 19, 2026 •

edited

Loading

VourMa commented Jun 19, 2026 •

edited

Loading