-
Notifications
You must be signed in to change notification settings - Fork 215
[DO NOT MERGE]Build tensorflow 2.21.0 and run tests. #10724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akritkbehera
wants to merge
7
commits into
cms-sw:IB/CMSSW_20_1_X/master
Choose a base branch
from
akritkbehera:Build_tensorflow_2.21.0
base: IB/CMSSW_20_1_X/master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
948cb84
Build tensorflow 2.21.0
akritkbehera a13d2fa
Fix packages that failed in CI and update ACTS
akritkbehera b223515
Abseil related fixes for abseil and torch-scatter
akritkbehera be5b589
Abseil related failures and failures due to tensorflow upgrade
akritkbehera 58825f8
Update Bazel options to use 8 parallel jobs
akritkbehera 8c25fd0
cap memory usage while building tensorflow-sources
8c24a1a
Add optimization flag for jpegxl encoding
akritkbehera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,41 +1,12 @@ | ||
| ### RPM external bazel 6.5.0 | ||
| ### RPM external bazel 7.7.0 | ||
| ## INCLUDE cpp-standard | ||
|
|
||
| Source: https://github.com/bazelbuild/bazel/releases/download/%{realversion}/bazel-%{realversion}-dist.zip | ||
|
|
||
| BuildRequires: java-env python3 python-python3 | ||
|
|
||
| # For some build steps, bazel uses a process-wrapper that is executed in an empty environment. | ||
| # Therefore, the wrapper is linked to the system library /lib64/libstdc++.so.6, and complains about | ||
| # a missing GLIBCXX_3.4.21 version when (e.g.) used during the compilation of tensorflow python | ||
| # modules invoked via swig. This mechanism of bazel is actually only useful in combination with its | ||
| # remote compilation features. When disabling the process-wrapper, the local environment is taken | ||
| # into account which is the desired behavior for us. For example, see: | ||
| # - https://github.com/bazelbuild/bazel/issues/4137 | ||
| # - https://github.com/bazelbuild/bazel/issues/4510 | ||
| # - https://github.com/tensorflow/tensorboard/issues/1611 | ||
|
|
||
| # configuration issue | ||
| # https://github.com/bazelbuild/bazel/issues/9392 | ||
| Patch0: bazel-3.7.0-patches | ||
| Patch1: bazel-absl | ||
|
|
||
| Source: https://github.com/bazelbuild/bazel/releases/download/%{realversion}/bazel-%{realversion}-linux-x86_64 | ||
| BuildRequires: java-env | ||
| %prep | ||
| %setup -q -c -n bazel-%{realversion} | ||
|
|
||
| %patch0 -p1 | ||
| %patch1 -p1 | ||
|
|
||
| %setup -T -c -n bazel-%{realversion} | ||
| cp %{_sourcedir}/bazel-%{realversion}-linux-x86_64 bazel | ||
| %build | ||
|
|
||
| export EXTRA_BAZEL_ARGS="--define=ABSOLUTE_JAVABASE=${JAVA_HOME} --jobs %{compiling_processes}" | ||
| export BAZEL_CXXOPTS="-Wno-error=deprecated:-std=c++%{cms_cxx_standard}" | ||
| ${JAVA_HOME}/bin/java -version 2>&1 | grep -E -i 'openjdk version "[1-9]' | ||
| if [ $(${JAVA_HOME}/bin/java -version 2>&1 | grep -E -i 'openjdk version "[1-9]' | sed -E 's|.* "([0-9]+)[.].*|\1|') -ge 17 ] ; then | ||
| export JNI_FLAGS="--add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED" | ||
| fi | ||
| bash ./compile.sh | ||
|
|
||
| # nothing to build — prebuilt binary | ||
| %install | ||
| mkdir %{i}/bin | ||
| cp output/bazel %{i}/bin/. | ||
| mkdir -p %{i}/bin | ||
| install -m 0755 bazel %{i}/bin/bazel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| ## INCLUDE cpp-standard | ||
| Patch0: patches/pip/py3-onnx | ||
| Requires: cmake protobuf py3-protobuf py3-six py3-typing-extensions py3-numpy py3-pytest-runner | ||
| Requires: py3-ml_dtypes | ||
| Requires: py3-ml_dtypes abseil-cpp | ||
| %define runpath_opts -n pb -n onnx | ||
| %define PipPreBuild export ONNX_ML=1;export CMAKE_ARGS="-DCMAKE_CXX_STANDARD=%{cms_cxx_standard} -DONNX_USE_PROTOBUF_SHARED_LIBS=ON -DProtobuf_USE_STATIC_LIBS=OFF -DCMAKE_PREFIX_PATH=%{cmake_prefix_path}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, this will break our ACTS/Traccc tests and possible the ongoing developments.
I'm in favour of updating ACTS, but we need to synchronise our work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can create a separate IBs for this then and track it.