Skip to content

Drive build of rocm-system packages from a single build file.#10714

Open
akritkbehera wants to merge 3 commits into
cms-sw:IB/CMSSW_20_1_X/rocm724from
akritkbehera:modularize_rocm_systems
Open

Drive build of rocm-system packages from a single build file.#10714
akritkbehera wants to merge 3 commits into
cms-sw:IB/CMSSW_20_1_X/rocm724from
akritkbehera:modularize_rocm_systems

Conversation

@akritkbehera

Copy link
Copy Markdown
Contributor

modular rocm-systems

@akritkbehera

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

cmsbuild commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @akritkbehera for branch IB/CMSSW_20_1_X/rocm724.

@akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@akritkbehera akritkbehera changed the title Modularize rocm stack Drive build of rocm-system packages from a single build file. Jul 9, 2026
Comment thread rocm-systems-build.file
-S %{_builddir}/rocm-systems/projects/%{?rocm_project}%{!?rocm_project:%{n}}
-B %{_builddir}/build
-DCMAKE_INSTALL_PREFIX=%{i}
-DCMAKE_BUILD_TYPE=Release

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_BUILD_TYPE=%{cmake_build_type}

@akritkbehera , this change will allow us to build any of these packages in debug mode via cmsBuild commandline --define cms_debug_packages=pkg-name option. By default cmake_build_type is Release

@fwyzard

fwyzard commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Random comment, just thinking out loud.

Since most packages are built from the same sources, would it make sense to actually have a single spec file that builds multiple target %packages ?

@smuzaffar

Copy link
Copy Markdown
Contributor

Random comment, just thinking out loud.

Since most packages are built from the same sources, would it make sense to actually have a single spec file that builds multiple target %packages ?

With current multi-spec files ( one per rocm core/library package) we can build multiple packages in parallel . With one spec we will build one package at a time and can takes 8-10 to build build that package

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f67d9b/54637/summary.html
COMMIT: 1a541eb
CMSSW: CMSSW_20_1_ROCM724_X_2026-07-08-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10714/54637/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 182 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 19 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3548186
  • DQMHistoTests: Total failures: 1578
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3546590
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #10714 was updated.

@akritkbehera

Copy link
Copy Markdown
Contributor Author

enable gpu

@akritkbehera

Copy link
Copy Markdown
Contributor Author

please test

@akritkbehera

Copy link
Copy Markdown
Contributor Author

@cmsbuild please abort

@akritkbehera

Copy link
Copy Markdown
Contributor Author

please test

@fwyzard

fwyzard commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This is only for ROCm 7.13 ?

@akritkbehera

Copy link
Copy Markdown
Contributor Author

Yes this for therock-rocm-7.13.

@fwyzard

fwyzard commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Ah OK.
Maybe the IB should be renamed :-)

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Failed Tests: amd_mi300xUnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f67d9b/54726/summary.html
COMMIT: 16dfdbf
CMSSW: CMSSW_20_1_ROCM724_X_2026-07-12-2300/el9_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10714/54726/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f67d9b/54726/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f67d9b/54726/git-merge-result

Comparison Summary

Summary:

  • You potentially added 310 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 43574 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3548186
  • DQMHistoTests: Total failures: 419542
  • DQMHistoTests: Total nulls: 346
  • DQMHistoTests: Total successes: 3128280
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 5.768 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 7.3 ): 5.768 KiB SiStrip/MechanicalView
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: found differences in 11 / 44 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants