Drive build of rocm-system packages from a single build file.#10714
Drive build of rocm-system packages from a single build file.#10714akritkbehera wants to merge 3 commits into
Conversation
|
please test |
|
A new Pull Request was created by @akritkbehera for branch IB/CMSSW_20_1_X/rocm724. @akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
| -S %{_builddir}/rocm-systems/projects/%{?rocm_project}%{!?rocm_project:%{n}} | ||
| -B %{_builddir}/build | ||
| -DCMAKE_INSTALL_PREFIX=%{i} | ||
| -DCMAKE_BUILD_TYPE=Release |
There was a problem hiding this comment.
| -DCMAKE_BUILD_TYPE=Release | |
| -DCMAKE_BUILD_TYPE=%{cmake_build_type} |
@akritkbehera , this change will allow us to build any of these packages in debug mode via cmsBuild commandline --define cms_debug_packages=pkg-name option. By default cmake_build_type is Release
|
Random comment, just thinking out loud. Since most packages are built from the same sources, would it make sense to actually have a single spec file that builds multiple target |
With current multi-spec files ( one per rocm core/library package) we can build multiple packages in parallel . With one spec we will build one package at a time and can takes 8-10 to build build that package |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f67d9b/54637/summary.html Comparison SummarySummary:
|
modular rocm-systems
1a541eb to
16dfdbf
Compare
|
Pull request #10714 was updated. |
|
enable gpu |
|
please test |
|
@cmsbuild please abort |
|
please test |
|
This is only for ROCm 7.13 ? |
|
Yes this for therock-rocm-7.13. |
|
Ah OK. |
|
-1 Failed Tests: amd_mi300xUnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
modular rocm-systems