[Backport] Add NNPuppiTauModel external spec and toolfile#10679
Conversation
Wires the new cms-hls4ml/NNPuppiTauModel package into the SCRAM build following the L1TSC4NGJetModel/AXOL1TL precedent, so TauNNIdHW can load its weights via hls4mlEmulator::ModelLoader instead of in-tree global arrays (avoids the symbol-clobbering bug class in cms-sw/cmssw#49632). Co-authored-by: artlbv <arturlbv@gmail.com>
v1.0.0 was missing NNPuppiTauModel_v1/NN/weights/w2.h, which broke the external build (parameters.h includes it). v1.0.1 fixes this. Co-authored-by: artlbv <arturlbv@gmail.com>
Co-authored-by: Malik Shahzad Muzaffar <shahzad.malik.muzaffar@cern.ch>
|
A new Pull Request was created by @artlbv for branch IB/CMSSW_17_0_X/master. @akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
|
|
cms-bot internal usage |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b77aa/54484/summary.html Comparison SummarySummary:
|
|
REMINDER @sextonkennedy, @ftenchini, @mandrenguyen: This PR was tested with cms-sw/cmssw#51294, please check if they should be merged together |
Backport of #10665
Summary
Adds the SCRAM build/install plumbing for the new cms-hls4ml/NNPuppiTauModel external package, following the same precedent already used for
L1TSC4NGJetModel/AXOL1TL. This package replaces the in-tree, un-namespaced hls4ml weight arrays (w2,b2, ...,w20,b20) previously compiled directly intoL1Trigger/Phase2L1ParticleFlow'sTauNNIdHW, which were vulnerable to ELF symbol interposition when multiple hls4ml models were loaded into the same process (the bug class behind cms-sw/cmssw#49632).This is part of a 3-PR migration:
cmsdistspec + toolfile so SCRAM builds/installs the new external.cmsswchanges to consume it viahls4mlEmulator::ModelLoader/hls4mlEmulator::Model.Changes
NNPuppiTauModel.spec(new) — RPM spec for the external, modeled onL1TSC4NGJetModel.spec/AXOL1TL.spec: fetches the release tarball fromcms-hls4ml/NNPuppiTauModel, builds viamakeagainsthls4mlEmulatorExtras/hls, installs into$PREFIX.scram-tools.file/tools/NNPuppiTauModel/nnpuppitaumodel.xml(new) — SCRAM toolfile exposingNNPUPPITAUMODEL_BASE/LIBDIRenvironment variables for the new external, modeled onl1tsc4ngjetmodel.xml.cmssw-tools.spec— addsRequires: NNPuppiTauModelalongside the existing L1-trigger model externals (L1TSC4NGJetModel,L1TSC82ProngJetModel, etc.), so it's pulled into every CMSSW release.Dependencies
Requires a tagged release of cms-hls4ml/NNPuppiTauModel to exist before this can build successfully.
PR validation
None yet.
cms-bot code-checks will perform the first real build test of the spec/toolfile/package Makefile chain.