Adding P2 L1T NNVtx by BenjaminRS · Pull Request #10605 · cms-sw/cmsdist

BenjaminRS · 2026-06-04T21:00:01Z

Adding into cmsdist the spec file for the Phase-2 Level-1 Trigger NNVtx Vertex Reconstruction.
The hls4ml files are kept here: https://github.com/cms-hls4ml/NNVtx
The gitlab page is here: https://gitlab.cern.ch/ml_l1/l1-vertex-finding

cmsbuild · 2026-06-04T21:00:29Z

A new Pull Request was created by @BenjaminRS for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2026-06-04T21:00:29Z

cms-bot internal usage

BenjaminRS · 2026-06-04T21:01:45Z

please test with cms-sw/cmssw#51008

cmsbuild · 2026-06-04T22:20:29Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebd0ad/53688/summary.html
COMMIT: 4b9ec45
CMSSW: CMSSW_17_0_X_2026-06-04-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10605/53688/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

34434.911

----- Begin Fatal Exception 05-Jun-2026 00:02:20 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

34434.0

----- Begin Fatal Exception 04-Jun-2026 23:56:29 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

34434.75

----- Begin Fatal Exception 04-Jun-2026 23:56:49 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

smuzaffar · 2026-06-08T21:19:05Z

@BenjaminRS , you also need to add scram tool file (cmsdist/scram-tools.file/tools/NNVtx/nnvtx.xml) for this new external ( see https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_20_0_X/master/scram-tools.file/tools/CICADA/cicada.xml or https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_20_0_X/master/scram-tools.file/tools/AXOL1TL/axol1tl.xml as exmaples). Also you need to add this new external as dependency of cmssw in https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_20_0_X/master/cmssw-tools.spec

cmsbuild · 2026-06-09T07:37:48Z

Pull request #10605 was updated.

BenjaminRS · 2026-06-09T07:38:25Z

please test with cms-sw/cmssw#51008

BenjaminRS · 2026-06-09T07:40:24Z

Hi @smuzaffar -- thank you for the tips. I set the tool revision="2" as seems to be done in all other .xml files I checked. But let me know if this should be 1 as it is the first time we include this hls4ml. Thanks

cmsbuild · 2026-06-09T07:50:21Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebd0ad/53761/summary.html
COMMIT: 6bbf5cb
CMSSW: CMSSW_20_0_X_2026-06-08-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10605/53761/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed External Build

I found compilation warning when building: See details on the summary page.

smuzaffar · 2026-06-09T07:53:11Z

@BenjaminRS , ideally this should have the revision=1 as this is new file ( and then in future increment the revision when tool definition changes). But for revision 2 does not hurt (it is just an indication of the revision of the tool definition).

By the way, looks like https://github.com/cms-hls4ml/NNVtx does not contin tag v1.0.0.tar.gz. build fails to download the sources

cmsbuild · 2026-06-09T09:13:44Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebd0ad/53764/summary.html
COMMIT: 026735d
CMSSW: CMSSW_20_0_X_2026-06-08-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10605/53764/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

34434.75

----- Begin Fatal Exception 09-Jun-2026 10:56:45 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

34496.0

----- Begin Fatal Exception 09-Jun-2026 10:54:12 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

34434.0

----- Begin Fatal Exception 09-Jun-2026 10:56:05 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

smuzaffar · 2026-06-09T16:02:03Z

please test with cms-sw/cmssw#51008

20.1.X IB is available now

cmsbuild · 2026-06-09T17:42:49Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebd0ad/53785/summary.html
COMMIT: 026735d
CMSSW: CMSSW_20_1_X_2026-06-09-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10605/53785/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebd0ad/53785/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebd0ad/53785/git-merge-result

Failed RelVals

34500.0

----- Begin Fatal Exception 09-Jun-2026 19:18:21 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

34496.0

----- Begin Fatal Exception 09-Jun-2026 19:18:22 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

34434.0

----- Begin Fatal Exception 09-Jun-2026 19:20:06 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

BenjaminRS · 2026-06-10T07:25:46Z

please test with cms-sw/cmssw#51008

There was a bug in the make file in the hls4ml repo. Fixed here

cmsbuild · 2026-06-10T09:02:11Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebd0ad/53810/summary.html
COMMIT: 026735d
CMSSW: CMSSW_20_1_X_2026-06-09-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10605/53810/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

34496.0

----- Begin Fatal Exception 10-Jun-2026 10:21:57 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

34500.0

----- Begin Fatal Exception 10-Jun-2026 10:22:13 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

34434.0

----- Begin Fatal Exception 10-Jun-2026 10:24:11 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=VertexProducer label='l1tVertexFinder'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

smuzaffar · 2026-06-10T09:13:28Z

@BenjaminRS , I only see L1TNNVtx_Pattern_Model_v0.so in the NNVtx/lib directory (/cvmfs/cms-ci.cern.ch/week1/PR_ba439238/el9_amd64_gcc13/external/NNVtx/1.0.0-84320ba4a694afd596fe782a45515293/lib64) but looks like cmssw PR is also looking for L1TNNVtx_Weight_Model_v0 ?

smuzaffar · 2026-06-10T09:16:07Z

@BenjaminRS , I see that you have fixed the build system cms-hls4ml/NNVtx#2 but we need a new tag of NNVtx with your fix and update NNVtx.spec here to use the new tag

BenjaminRS · 2026-06-10T09:16:32Z

Hi @smuzaffar - this is what this morning's PR fixed: cms-hls4ml/NNVtx#2
When I tested locally I saw the 3 files being created under the lib64 folder

cmsbuild · 2026-06-10T09:27:28Z

Pull request #10605 was updated.

BenjaminRS · 2026-06-10T09:27:51Z

please test with cms-sw/cmssw#51008

now updated to v1.0.1 which has the bug fix Updating makefile to cp the 3 model files to the lib folder cms-hls4ml/NNVtx#2 included

cmsbuild · 2026-06-10T12:35:53Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebd0ad/53820/summary.html
COMMIT: 902ed82
CMSSW: CMSSW_20_1_X_2026-06-09-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10605/53820/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebd0ad/53820/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebd0ad/53820/git-merge-result

Failed RelVals

34500.0

----- Begin Fatal Exception 10-Jun-2026 13:27:23 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'Phase2L1GTProducer'
   [2] Prefetching for module L1GTProducer/'l1tGTProducer'
   [3] Prefetching for module L1TrackJetEmulatorProducer/'l1tTrackJetsExtendedEmulation'
   [4] Calling method for module L1TrackVertexAssociationProducer/'l1tTrackVertexAssociationProducerExtendedForJets'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<l1t::io_v1::Vertex>
Looking for module label: l1tVertexFinder
Looking for productInstanceName: L1Vertices

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

34496.0

----- Begin Fatal Exception 10-Jun-2026 13:27:25 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'Phase2L1GTProducer'
   [2] Prefetching for module L1GTProducer/'l1tGTProducer'
   [3] Prefetching for module L1TrackJetEmulatorProducer/'l1tTrackJetsExtendedEmulation'
   [4] Calling method for module L1TrackVertexAssociationProducer/'l1tTrackVertexAssociationProducerExtendedForJets'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<l1t::io_v1::Vertex>
Looking for module label: l1tVertexFinder
Looking for productInstanceName: L1Vertices

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

34434.0

----- Begin Fatal Exception 10-Jun-2026 13:29:14 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'Phase2L1GTProducer'
   [2] Prefetching for module L1GTProducer/'l1tGTProducer'
   [3] Prefetching for module L1TrackJetEmulatorProducer/'l1tTrackJetsExtendedEmulation'
   [4] Calling method for module L1TrackVertexAssociationProducer/'l1tTrackVertexAssociationProducerExtendedForJets'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<l1t::io_v1::Vertex>
Looking for module label: l1tVertexFinder
Looking for productInstanceName: L1Vertices

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

Adding P2 L1T NNVtx

4b9ec45

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Jun 4, 2026

cmsbuild added tests-started requires-external and removed tests-pending labels Jun 4, 2026

cmsbuild added tests-rejected and removed tests-started labels Jun 4, 2026

smuzaffar changed the base branch from IB/CMSSW_17_0_X/master to IB/CMSSW_20_0_X/master June 5, 2026 16:47

Adding missign configuration files for NNVtx

6bbf5cb

cmsbuild added tests-pending and removed tests-rejected requires-external labels Jun 9, 2026

cmsbuild added tests-started requires-external and removed tests-pending labels Jun 9, 2026

cmsbuild added tests-rejected and removed tests-started labels Jun 9, 2026

cmsbuild added tests-started and removed tests-rejected labels Jun 9, 2026

cmsbuild added tests-rejected and removed tests-started labels Jun 9, 2026

cmsbuild added tests-started and removed tests-rejected labels Jun 10, 2026

cmsbuild added tests-rejected and removed tests-started labels Jun 10, 2026

Updating to NNVtx v1.0.1

902ed82

cmsbuild added tests-pending and removed tests-rejected requires-external labels Jun 10, 2026

cmsbuild added tests-started requires-external and removed tests-pending labels Jun 10, 2026

cmsbuild added tests-rejected and removed tests-started labels Jun 10, 2026

Uh oh!

Conversation

BenjaminRS commented Jun 4, 2026

Uh oh!

cmsbuild commented Jun 4, 2026

Uh oh!

cmsbuild commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenjaminRS commented Jun 4, 2026

Uh oh!

cmsbuild commented Jun 4, 2026

Failed RelVals

Uh oh!

smuzaffar commented Jun 8, 2026

Uh oh!

cmsbuild commented Jun 9, 2026

Uh oh!

BenjaminRS commented Jun 9, 2026

Uh oh!

BenjaminRS commented Jun 9, 2026

Uh oh!

cmsbuild commented Jun 9, 2026

Failed External Build

Uh oh!

smuzaffar commented Jun 9, 2026

Uh oh!

cmsbuild commented Jun 9, 2026

Failed RelVals

Uh oh!

smuzaffar commented Jun 9, 2026

Uh oh!

cmsbuild commented Jun 9, 2026

Failed RelVals

Uh oh!

BenjaminRS commented Jun 10, 2026

Uh oh!

cmsbuild commented Jun 10, 2026

Failed RelVals

Uh oh!

smuzaffar commented Jun 10, 2026

Uh oh!

smuzaffar commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenjaminRS commented Jun 10, 2026

Uh oh!

cmsbuild commented Jun 10, 2026

Uh oh!

BenjaminRS commented Jun 10, 2026

Uh oh!

cmsbuild commented Jun 10, 2026

Failed RelVals

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmsbuild commented Jun 4, 2026 •

edited

Loading

smuzaffar commented Jun 10, 2026 •

edited

Loading