Skip to content

Upgrade EvtGen to v03.00.00#10580

Open
kawaho wants to merge 7 commits into
cms-sw:IB/CMSSW_17_0_X/masterfrom
kawaho:EvtGenv3
Open

Upgrade EvtGen to v03.00.00#10580
kawaho wants to merge 7 commits into
cms-sw:IB/CMSSW_17_0_X/masterfrom
kawaho:EvtGenv3

Conversation

@kawaho

@kawaho kawaho commented May 25, 2026

Copy link
Copy Markdown

This commits upgrade EvtGen to v03.00.00, which

  • is now thread-safe, allowing multithreading in production
  • adds new final state photon radiation models in Sherpa/Photon++ and Vincia
  • includes new physics models and decay table implemented by Belle 2

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @kawaho for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented May 25, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@akritkbehera

Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51029

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53469/summary.html
COMMIT: 8089a4f
CMSSW: CMSSW_17_0_X_2026-05-25-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10580/53469/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 10 errors in the following unit tests:

---> test GeneratorInterfaceEvtGenInterfaceTest had ERRORS
---> test TestGeneratorInterfaceEvtGenInterface_bplus had ERRORS
---> test test_MC_22_crosscheck had ERRORS
and more ...

Failed RelVals

  • 25202.0A fatal system signal has occurred: segmentation violation
  • 25.0A fatal system signal has occurred: segmentation violation
  • 1306.0A fatal system signal has occurred: segmentation violation
Expand to see more relval errors ...

Failed AddOn Tests

A fatal system signal has occurred: segmentation violation
----- Begin Fatal Exception 26-May-2026 00:52:06 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Attempted to open logical file file:RelVal_Raw_Fake_MC.root.
      [b] Failed to open the file with physical name file:RelVal_Raw_Fake_MC.root.
      [c] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 26-May-2026 00:52:28 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Attempted to open logical file file:RelVal_Raw_Fake_MC.root.
      [b] Failed to open the file with physical name file:RelVal_Raw_Fake_MC.root.
      [c] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@kawaho

kawaho commented May 26, 2026

Copy link
Copy Markdown
Author

@akritkbehera how do I run these tests locally? They look strange because all the errors seem to be coming from GEANT4 which is not changed in this commit.

@smuzaffar

Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51029 using full cmssw

lets build full cmssw

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53479/summary.html
COMMIT: 8089a4f
CMSSW: CMSSW_17_0_X_2026-05-25-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10580/53479/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53479/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53479/git-merge-result

Failed Unit Tests

I found 10 errors in the following unit tests:

---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_23_crosscheck had ERRORS
---> test GeneratorInterfaceEvtGenInterfaceTest had ERRORS
and more ...

Failed RelVals

  • 25202.0A fatal system signal has occurred: segmentation violation
  • 25.0A fatal system signal has occurred: segmentation violation
  • 1306.0A fatal system signal has occurred: segmentation violation
Expand to see more relval errors ...

Failed AddOn Tests

A fatal system signal has occurred: segmentation violation
----- Begin Fatal Exception 26-May-2026 13:12:11 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Attempted to open logical file file:RelVal_Raw_Fake_MC.root.
      [b] Failed to open the file with physical name file:RelVal_Raw_Fake_MC.root.
      [c] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 26-May-2026 13:12:33 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Attempted to open logical file file:RelVal_Raw_Fake_MC.root.
      [b] Failed to open the file with physical name file:RelVal_Raw_Fake_MC.root.
      [c] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@kawaho

kawaho commented May 27, 2026

Copy link
Copy Markdown
Author

The GEANT4 crush is most likely due to the dependence on SimG4Core I introduced in GeneratorInterface/ExternalDecays. This should be resolved by #51041. Let's wait for it to be merged so I can modify my commit according to the new build

@kawaho

kawaho commented May 28, 2026

Copy link
Copy Markdown
Author

@smuzaffar

Ready to test. ThreadHandoff is moved now in the new commit.

@smuzaffar

Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51029 using full cmssw

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Pull request #10580 was updated.

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Pull request #10580 was updated.

@smuzaffar

Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51029

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53816/summary.html
COMMIT: b341739
CMSSW: CMSSW_17_0_X_2026-06-09-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10580/53816/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed External Build

I found compilation error when building:

|+++ a/R03-00-00/EvtGenExternal/EvtSherpaPhotons.hh.orig	2026-05-22 11:42:50.932434652 -0500 
|+++ b/R03-00-00/EvtGenExternal/EvtSherpaPhotons.hh	2026-05-22 11:42:23.583029106 -0500
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.eXjGjf (%prep)

RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.eXjGjf (%prep)

check-external+hls4mlEmulatorExtras+1.1.4-66f94ba9a1f0ab77dcb08388a4fb59d4 done


@smuzaffar

Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51029

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #10580 was updated.

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53817/summary.html
COMMIT: 81cf1d3
CMSSW: CMSSW_17_0_X_2026-06-09-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10580/53817/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4316359
  • DQMHistoTests: Total failures: 58
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4316281
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 232 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@smuzaffar

Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51029

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53947/summary.html
COMMIT: 81cf1d3
CMSSW: CMSSW_17_0_X_2026-06-15-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10580/53947/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4337615
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4337592
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 232 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@smuzaffar

Copy link
Copy Markdown
Contributor

please build with cms-sw/cmssw#51029

@cmsbuild

cmsbuild commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/54448/summary.html
COMMIT: 81cf1d3
CMSSW: CMSSW_17_0_X_2026-07-01-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10580/54448/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/54448/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/54448/git-merge-result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants