Skip to content

Rivet 4.1.2. and Yoda 2.1.2#10446

Merged
smuzaffar merged 1 commit into
cms-sw:IB/CMSSW_16_1_X/masterfrom
mseidel42:rivet412master
Mar 27, 2026
Merged

Rivet 4.1.2. and Yoda 2.1.2#10446
smuzaffar merged 1 commit into
cms-sw:IB/CMSSW_16_1_X/masterfrom
mseidel42:rivet412master

Conversation

@mseidel42

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mseidel42 for branch IB/CMSSW_16_1_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@smuzaffar

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bab8e/52248/summary.html
COMMIT: 271a359
CMSSW: CMSSW_16_1_X_2026-03-24-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10446/52248/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bab8e/52248/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bab8e/52248/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMOnlineClient-gem_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4185300
  • DQMHistoTests: Total failures: 23
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4185257
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@smuzaffar

Copy link
Copy Markdown
Contributor

test parameters:

  • enable = threading
  • workflow_threading = 534.0,536.0
  • workflow = 534.0,536.0

@smuzaffar

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bab8e/52266/summary.html
COMMIT: 271a359
CMSSW: CMSSW_16_1_X_2026-03-25-1100/el8_amd64_gcc13
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10446/52266/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bab8e/52266/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bab8e/52266/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4187078
  • DQMHistoTests: Total failures: 47
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4187011
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
  • Checked 231 log files, 200 edm output root files, 55 DQM output files
  • TriggerResults: no differences found

@smuzaffar

Copy link
Copy Markdown
Contributor

assign generators

@cms-sw/generators-l2 can you please review this change? It updates rivet and yoda versions?

@smuzaffar

Copy link
Copy Markdown
Contributor

+externals

@cmsbuild

Copy link
Copy Markdown
Contributor

New categories assigned: generators

@lviliani,@mkirsano,@sensrcn,@theofil you have been requested to review this Pull request/Issue and eventually sign? Thanks

@smuzaffar

Copy link
Copy Markdown
Contributor

@cms-sw/generators-l2 please review if this should go in next 16.1.X pre-release

@lviliani

Copy link
Copy Markdown

+generators

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar

Copy link
Copy Markdown
Contributor

thanks, lets get this in 16.1.X 11h IB

@smuzaffar
smuzaffar merged commit abc3ad2 into cms-sw:IB/CMSSW_16_1_X/master Mar 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants