Add L1TSC82ProngJetModel by henripetrow · Pull Request #10337 · cms-sw/cmsdist

henripetrow · 2026-02-11T11:26:44Z

This PR adds one new package for an upcoming CMSSW PR for the Phase 2 Level 1 Trigger 2-Prong Jet Tagging Model.

cmsbuild · 2026-02-11T11:27:07Z

A new Pull Request was created by @henripetrow for branch IB/CMSSW_16_1_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2026-02-11T11:27:08Z

cms-bot internal usage

smuzaffar · 2026-02-12T10:14:29Z

@@ -0,0 +1,6 @@
+<tool name="l1tsc82prongjetmodel" version="@TOOL_VERSION@" revision="1">


@henripetrow , please add .xml extension to this file i.e. it should be l1tsc82prongjetmodel.xml

Added the .xml extension.

smuzaffar · 2026-02-12T10:15:45Z

assign l1

@cms-sw/l1-l2 , if no objections on this addition then please start the tests here

cmsbuild · 2026-02-12T10:16:07Z

New categories assigned: l1

@BenjaminRS,@quinnanm you have been requested to review this Pull request/Issue and eventually sign? Thanks

makortel · 2026-02-12T19:36:26Z

@@ -0,0 +1,13 @@
+### RPM external L1TSC82ProngJetModel 0.0.0
+Source: https://github.com/cms-hls4ml/%{n}/archive/refs/tags/v%{realversion}.tar.gz


On a quick look the repository seems to contain binary files (.so, .o`), I'd suggest to clean them up.

Also many files seem to contain code that is not in a unique namespace increasing the risk for ODR violations. For example

https://github.com/cms-hls4ml/L1TSC82ProngJetModel/blob/v0.0.0/L1TSC82ProngJetModel_v0/NN/parameters.h

https://github.com/cms-hls4ml/L1TSC82ProngJetModel/blob/v0.0.0/L1TSC82ProngJetModel_v0/NN/weights/b14.h (and other files in weights directory)

Removed binary files. Looking on changing the namespace.

cmsbuild · 2026-03-04T06:34:02Z

Pull request #10337 was updated.

cmsbuild · 2026-03-26T10:18:52Z

Pull request #10337 was updated.

smuzaffar · 2026-03-26T10:20:36Z

please test

@henripetrow , I have updated the tag to 0.0.1 where you have cleaned up the shared objects and added the namespace

cmsbuild · 2026-03-26T10:23:37Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4494de/52282/summary.html
COMMIT: 8961348
CMSSW: CMSSW_16_1_X_2026-03-25-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10337/52282/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed External Build

I found compilation warning when building: See details on the summary page.

smuzaffar · 2026-03-26T10:43:39Z

please test

cmsbuild · 2026-03-26T10:43:46Z

Pull request #10337 was updated.

cmsbuild · 2026-03-26T14:37:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4494de/52283/summary.html
COMMIT: b8d3933
CMSSW: CMSSW_16_1_X_2026-03-25-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10337/52283/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4494de/52283/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4494de/52283/git-merge-result

Comparison Summary

Summary:

You potentially removed 5 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 21 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4179457
DQMHistoTests: Total failures: 16593
DQMHistoTests: Total nulls: 76
DQMHistoTests: Total successes: 4162768
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 2032.074 KiB( 52 files compared)
DQMHistoSizes: changed ( 18434.0,... ): 437.104 KiB HLT/JME
DQMHistoSizes: changed ( 18434.0,... ): 36.501 KiB HLT/HLTEgammaValidation
DQMHistoSizes: changed ( 18434.0,... ): 25.643 KiB HLT/EGM
DQMHistoSizes: changed ( 18434.0,... ): 14.854 KiB HLT/Filters
DQMHistoSizes: changed ( 18434.0,... ): 11.537 KiB HLT/JetMET
DQMHistoSizes: changed ( 18434.0,... ): 9.777 KiB HLT/Muon
DQMHistoSizes: changed ( 18434.0,... ): 3.020 KiB HLT/Higgs
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: found differences in 2 / 51 workflows

smuzaffar · 2026-03-27T08:52:31Z

please test for el9_amd64_gcc15

smuzaffar · 2026-03-27T13:14:55Z

+externals

cmsbuild · 2026-03-27T16:25:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4494de/52306/summary.html
COMMIT: b8d3933
CMSSW: CMSSW_16_1_X_2026-03-26-2300/el9_amd64_gcc15
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10337/52306/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 273 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 102377 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186890
DQMHistoTests: Total failures: 533022
DQMHistoTests: Total nulls: 315
DQMHistoTests: Total successes: 3653533
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -7.7250000000000005 KiB( 52 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.352 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): -0.176 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 17034.0 ): 0.586 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 18634.0 ): -1.520 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 18634.0 ): 0.146 KiB HLT/JME
DQMHistoSizes: changed ( 2023.0020001,... ): -0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0000001 ): -0.016 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0010001,... ): 0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0020001 ): -0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0030001 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0040001 ): ...
Checked 227 log files, 198 edm output root files, 53 DQM output files

henripetrow added 2 commits February 3, 2026 11:39

Initial commit

25dd9c9

Merge branch 'cms-sw:IB/CMSSW_16_1_X/master' into IB/CMSSW_16_1_X/master

1a4f973

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Feb 11, 2026

henripetrow mentioned this pull request Feb 11, 2026

[L1T] L1TSC82ProngJetModel (Phase 2) cms-sw/cmssw#50115

Closed

smuzaffar reviewed Feb 12, 2026

View reviewed changes

cmsbuild added the l1-pending label Feb 12, 2026

makortel reviewed Feb 12, 2026

View reviewed changes

henripetrow mentioned this pull request Feb 17, 2026

L1TSC82ProngJetModel p2l1pfp/cmssw#150

Merged

Added .xml extension.

8f854ce

L1TSC82ProngJetModel: update to tag 0.0.1 , cleanup of shared objects

8961348

cmsbuild added tests-started and removed tests-pending labels Mar 26, 2026

cmsbuild added tests-rejected and removed tests-started labels Mar 26, 2026

fix L1TSC82ProngJetModel spec and toolfile definition

b8d3933

cmsbuild added tests-started and removed tests-rejected labels Mar 26, 2026

cmsbuild added tests-approved and removed tests-started labels Mar 26, 2026

cmsbuild added externals-approved and removed externals-pending labels Mar 27, 2026

smuzaffar merged commit 0019c47 into cms-sw:IB/CMSSW_16_1_X/master Mar 27, 2026
13 of 14 checks passed

		@@ -0,0 +1,6 @@
		<tool name="l1tsc82prongjetmodel" version="@TOOL_VERSION@" revision="1">

		@@ -0,0 +1,13 @@
		### RPM external L1TSC82ProngJetModel 0.0.0
		Source: https://github.com/cms-hls4ml/%{n}/archive/refs/tags/v%{realversion}.tar.gz

Uh oh!

Conversation

henripetrow commented Feb 11, 2026

Uh oh!

cmsbuild commented Feb 11, 2026

Uh oh!

cmsbuild commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

henripetrow Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

smuzaffar commented Feb 12, 2026

Uh oh!

cmsbuild commented Feb 12, 2026

Uh oh!

makortel Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

henripetrow Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Mar 4, 2026

Uh oh!

cmsbuild commented Mar 26, 2026

Uh oh!

smuzaffar commented Mar 26, 2026

Uh oh!

cmsbuild commented Mar 26, 2026

Failed External Build

Uh oh!

smuzaffar commented Mar 26, 2026

Uh oh!

cmsbuild commented Mar 26, 2026

Uh oh!

cmsbuild commented Mar 26, 2026

Comparison Summary

Uh oh!

smuzaffar commented Mar 27, 2026

Uh oh!

smuzaffar commented Mar 27, 2026

Uh oh!

Uh oh!

cmsbuild commented Mar 27, 2026

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented Feb 11, 2026 •

edited

Loading