fix(devops): synchronize canvas cache updates - #963
Open
dajiaohuang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
<type>(optional scope): <description>(Optional) Translate the PR title into Chinese.
fix(devops): 同步 canvas 缓存更新(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
CreateCanvasassignedGraphContainer.CanvasInfoafter releasing the container service mutex, whileGetCanvasread the pointer under the corresponding read lock. Concurrent canvas creation and lookup therefore produced read/write and write/write race reports.This change protects the cache assignment with the service mutex and adds a concurrent regression test. The test reproduces the race before this change and passes under the race detector afterward.
Validation:
go test -gcflags='all=-N -l' ./internal/service -run '^Test_containerServiceImpl_CreateCanvas$' -count=10(Windows, Go 1.26.3)go test -race -gcflags='all=-N -l' ./internal/service -run '^Test_containerServiceImpl_CreateCanvas$' -count=10(Linux, Go 1.25.6)go vet ./internal/servicegit diff --check(Optional) Which issue(s) this PR fixes:
Fixes #961
(optional) The PR that updates user documentation:
Not required.