Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devops/internal/service/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func (s *containerServiceImpl) AddGraphInfo(rootGN string, rootGI *compose.Graph
s.mu.Lock()
defer s.mu.Unlock()

if s.totalGraphNum > maxGraphNum {
if s.totalGraphNum >= maxGraphNum {
return "", fmt.Errorf("too many graph, max=%d", maxGraphNum)
}

Expand Down
20 changes: 20 additions & 0 deletions devops/internal/service/container_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,26 @@ func Test_containerServiceImpl_AddGraphInfo(t *testing.T) {
assert.Equal(t, s.graphNameCounter[mockGraphName], 10)
})

t.Run("reject graph beyond limit", func(t *testing.T) {
mockGraphName := "mock_graph"
s := &containerServiceImpl{
container: map[string]*model.GraphContainer{},
graphNameCounter: map[string]int{},
}

for i := 0; i < maxGraphNum; i++ {
_, err := s.AddGraphInfo(mockGraphName, &compose.GraphInfo{})
if !assert.NoError(t, err) {
return
}
}

_, err := s.AddGraphInfo(mockGraphName, &compose.GraphInfo{})
assert.EqualError(t, err, fmt.Sprintf("too many graph, max=%d", maxGraphNum))
assert.Equal(t, maxGraphNum, s.totalGraphNum)
assert.Len(t, s.container, maxGraphNum)
})

t.Run("add graph info with subGraph, once", func(t *testing.T) {
mockGraphName := "mock_graph"
s := &containerServiceImpl{
Expand Down
Loading