fix(claude): support custom HTTP clients for Bedrock - #931
Open
March-77 wants to merge 1 commit into
Open
Conversation
March-77
marked this pull request as ready for review
July 23, 2026 03:36
Author
|
Revalidated on 2026-08-23 against current main (
No code update appears necessary; an approving review is the remaining blocker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
<type>(optional scope): <description>(Optional) Translate the PR title into Chinese.
N/A
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
NewChatModelinstead of panicking insidebedrock.WithLoadDefaultConfigBuildableClientonly when custom CA bundle resolution requires itRoundTripper, Web Identity/STS credential retrieval, request signing, and the final Bedrock requestThis supersedes the closed, unmerged #717 by covering both the API request path and the
AWS_CA_BUNDLEincompatibility.Validation:
GOTOOLCHAIN=go1.25.6 go test -gcflags="all=-N -l" ./... -count=1GOTOOLCHAIN=go1.25.6 go vet ./...golangci-lint run --no-config --default=standard --new-from-rev=origin/main ./...zh(optional): N/A
(Optional) Which issue(s) this PR fixes:
Fixes #712
(optional) The PR that updates user documentation:
N/A