fix(local): follow directory symlinks in GlobInfo - #930
Open
March-77 wants to merge 1 commit into
Open
Conversation
March-77
marked this pull request as ready for review
July 23, 2026 03:36
Author
|
Revalidated on 2026-08-23 against current main (
No code update appears necessary. A maintainer decision on default-vs-opt-in behavior relative to #867, plus an approving review, would unblock this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
fix(local): 让 GlobInfo 跟随目录软链接
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
Local.GlobInfocurrently usesfilepath.WalkDir, which treats a directory symlink as a leaf. As a result, skill discovery such as*/SKILL.mdreturns nothing when the skills root or an individual skill directory is symlinked.This change:
os.SameFile, so self/ancestor links terminate without suppressing independent aliases to the same target;Tests cover a symlink root, multiple directory aliases, a directory cycle, and file/broken symlinks. The earlier #863 attempt was closed unmerged without review; this implementation is deliberately narrower (no
GrepRawchange) and avoids its global visited set, which could drop valid alias paths.Validation:
go test -race . -run '^TestGlobInfo$' -count=1go test ./... -run '^TestGlobInfo$' -count=1go vet ./...golangci-lint(0 issues)The local Windows account lacks symlink-creation privilege, so real symlink subtests are skipped there; the repository's Linux CI executes them. A full Windows module run was also attempted and reached existing Unix-specific failures in
TestLsInfoandTestGrepRaw.zh(optional):
为
GlobInfo增加目录软链接跟随能力,保留软链接逻辑路径,并以当前递归祖先链检测循环;同时保持文件软链接和坏链接原有的匹配语义。(Optional) Which issue(s) this PR fixes:
Fixes #746
(optional) The PR that updates user documentation:
The module-level English and Chinese READMEs are updated in this PR.