fix(milvus2): serialize range search parameters as ANN params - #926
Open
tonghzhang wants to merge 1 commit into
Open
fix(milvus2): serialize range search parameters as ANN params#926tonghzhang wants to merge 1 commit into
tonghzhang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix, tests
Check the PR title.
(Optional) Translate the PR title into Chinese.
fix: 修复范围搜索参数未正确生效的问题
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
This fixes #893
Summary
Fixes Milvus range search parameter serialization.
Previously, radius and range_filter were serialized as top-level search parameters, leaving the ANN params object empty. Since Milvus expects these range constraints inside ANN params, the configured range filter was not applied correctly.
Changes
Build range search parameters with index.CustomAnnParam.
Pass the parameters through WithAnnParam.
Serialize radius and the optional range_filter inside the ANN params object.
Add regression assertions to TestRange_BuildSearchOption.
Verify that radius and range_filter are not present as top-level search parameters.
Tests
go build ./search_mode — PASS
go vet -tests=false ./search_mode — PASS
go test ./search_mode — not completed locally on Windows because of a mockey v1.4.0 runtime compatibility issue
Automatically closes linked issue when PR is merged.
Eg:
Fixes #<issue number>, orFixes (paste link of issue).(optional) The PR that updates user documentation: