fix(workers-utils): reject null observability config instead of crashing#14746
Open
samarth70 wants to merge 1 commit into
Open
fix(workers-utils): reject null observability config instead of crashing#14746samarth70 wants to merge 1 commit into
samarth70 wants to merge 1 commit into
Conversation
validateObservability only guarded against undefined, so a null value (valid in JSON/JSONC config) passed the typeof === "object" check and then threw a TypeError while reading val.enabled. Reject null with the same diagnostic the sibling cache validator already emits, and add a regression test. Signed-off-by: Sam Agarwal <samarthagrawal526@gmail.com>
🦋 Changeset detectedLatest commit: 58bdb41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
NuroDev
and removed request for
a team
July 17, 2026 15:10
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no existing issue for this; it's a small validation bug found while reading the config validators.
validateObservabilityguards only againstundefined:Because
typeof null === "object", anullvalue falls through this check. The function then readsval.enabled, which throws:nullis reachable through real config, since Wrangler accepts JSON/JSONC where"observability": nullis valid. Instead of a clean diagnostic, the user gets a stack trace.The sibling
validateCachevalidator already handles this correctly:This change brings
validateObservabilityin line with it, soobservability: nullnow produces:which matches how every other object-typed field (
browser,durable_objects,cache, ...) already reports anullvalue.The added test fails on the current code with the
TypeErrorabove and passes with the fix. Verified withpnpm test -F @cloudflare/workers-utils(431 passed), plusoxlintandoxfmtclean.