[wrangler] Extract remote bindings into a package by penalosa · Pull Request #14720 · cloudflare/workers-sdk

penalosa · 2026-07-16T14:02:07Z

Extract the remote bindings implementation from Wrangler into the private @cloudflare/remote-bindings package while preserving Wrangler's public API through logger-injecting wrappers.

This also narrows the copied development runtime to the functionality remote bindings use, makes the package directly importable as ESM, registers a workers.dev subdomain when required for preview sessions, and retains existing proxy sessions when bindings are updated.

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: this is an internal implementation extraction with no new user-facing API.

A picture of a cute animal (not mandatory, but encouraged)

changeset-bot · 2026-07-16T14:02:21Z

🦋 Changeset detected

Latest commit: 79808aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-07-16T14:03:23Z

✅ All changesets look good

ask-bonk · 2026-07-16T14:06:51Z

I'm Bonk, and I've done a quick review of your PR.

Extracts the remote bindings implementation into a private @cloudflare/remote-bindings package and keeps Wrangler's public API via logger-injecting wrappers.

One actionable issue:

1. Unused import will fail lint — packages/wrangler/src/user/access.ts:9

This PR removes the isNonInteractiveOrCI argument from the packageGetAccessHeaders(...) call (workers-auth's getAccessHeaders now imports it directly from @cloudflare/workers-utils), which leaves this import dead:

import { isNonInteractiveOrCI } from "@cloudflare/workers-utils";

isNonInteractiveOrCI is no longer referenced anywhere in the file except the leading comment. The repo's unused-imports/no-unused-vars rule raises errors, so pnpm check / CI will fail. Suggested fix — remove the import:

import { logger } from "../logger";

(applied to lines 9-10, dropping the unused import and keeping the logger import). While you're there, the leading comment (lines 2-3) still says the wrapper "injects wrangler's logger singleton and isNonInteractiveOrCI predicate" — that's now stale and should drop the isNonInteractiveOrCI mention.

Nit (non-blocking): getCloudflareAccessHeaders in packages/workers-auth/src/access.ts:182-184 still declares isNonInteractiveOrCI: () => boolean in its options and passes it through to getAccessHeaders, which no longer reads it. Harmless at runtime, but the migration is left half-done — worth tidying for consistency.

ask-bonk · 2026-07-16T14:06:58Z

Posted the review as a top-level PR comment on #14720 (the inline suggestion returned a 422 because the unused-import line falls outside the diff hunk, so I fell back to a PR comment per the instructions).

Summary of findings:

Actionable: packages/wrangler/src/user/access.ts:9 — isNonInteractiveOrCI import is now dead after this PR removed it from the packageGetAccessHeaders(...) call. The repo's unused-imports/no-unused-vars rule errors on this, so pnpm check/CI will fail. Provided a suggestion to drop the import and flagged the stale leading comment.
Nit: getCloudflareAccessHeaders in packages/workers-auth/src/access.ts still declares/threads isNonInteractiveOrCI even though getAccessHeaders no longer reads it — harmless but an incomplete migration.

Everything else (the logger singleton init timing, retryOnAPIFailure signature change and its call sites, changeset scope, private-package handling) checked out.

github run

workers-devprod · 2026-07-16T15:24:35Z

Codeowners approval required for this PR:

✅ @cloudflare/wrangler

Show detailed file reviewers

pkg-pr-new · 2026-07-16T16:23:16Z

@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14720

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@14720

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14720

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14720

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14720

miniflare

npm i https://pkg.pr.new/miniflare@14720

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14720

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14720

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14720

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14720

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14720

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14720

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14720

wrangler

npm i https://pkg.pr.new/wrangler@14720

commit: 2b3ea8b

petebacondarwin · 2026-07-20T11:03:20Z

This also narrows the copied development runtime to the functionality remote bindings use, makes the package directly importable as ESM, registers a workers.dev subdomain when required for preview sessions, and retains existing proxy sessions when bindings are updated.

What is the goal here? It feels a bit weird to be making these copies (even if they are narrower). This is non-trivial code and any bug in one is likely to be in the other, making an additional maintenance burden. Was there no way to just share the code?

penalosa · 2026-07-20T12:32:41Z

What is the goal here? It feels a bit weird to be making these copies (even if they are narrower). This is non-trivial code and any bug in one is likely to be in the other, making an additional maintenance burden. Was there no way to just share the code?

I initially tried that, but pulling the entirety of DevEnv outside of Wrangler proved quite complex, and ended up with similarly hard to review diffs. The goal here is to pull out out remote bindings as a distinct thing from DevEnv, so that we can use remote bindings in Vite and Vitest without depending on Wrangler.

One aspect here is that I don't know that these codebases will necessarily evolve in the same direction. We may end up with remote bindings being powered by some more dedicated system in the future, and we may end up with the remote aspect of DevEnv being deprecated at some point.

workers-devprod

Codeowners reviews satisfied

…oller.ts Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>

- Drop the empty `WranglerLog` wrapper — `ProxyControllerLogger` now extends Miniflare's `Log` directly - De-wrangler-ify the extracted package — `ProxyController` log prefix and the tail WebSocket `User-Agent` now say `remote-bindings` rather than `wrangler` - Move runtime dependencies out of `devDependencies` into `dependencies`, matching the convention in other packages

…artup `startRemoteProxySession` only unwrapped `RemoteSessionAuthenticationError` at the error event's direct `cause`, so a `UserError` surfaced asynchronously (e.g. the Miniflare user-error case) fell through to being wrapped in a generic `Error`. That made Wrangler treat it as an unexpected internal error (bug prompt + Sentry report) rather than a clean user-facing error. Surface a directly-emitted `UserError` verbatim, and walk the error event's cause chain for a `RemoteSessionAuthenticationError` (mirroring the original `findRemoteSessionAuthError`). Generic API errors — which also extend `UserError` via `APIError` — still fall through to the "Failed to start the remote proxy session" wrapper. Adds regression tests covering each case.

workers-devprod added this to workers-sdk Jul 16, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Jul 16, 2026

penalosa force-pushed the penalosa/manual-remote-bindings branch from 55ca99a to 235afa1 Compare July 16, 2026 14:43

penalosa marked this pull request as ready for review July 16, 2026 15:24

penalosa requested a review from workers-devprod as a code owner July 16, 2026 15:24

workers-devprod requested review from a team and edmundhung and removed request for a team July 16, 2026 15:24

This comment was marked as resolved.

Sign in to view

emily-shen added the ci:run-remote-tests Run remote/E2E tests that require Cloudflare API credentials label Jul 16, 2026

akim136 mentioned this pull request Jul 17, 2026

[wrangler] Handle queue bindings in remote dev #14608

Open

5 tasks

This comment was marked as resolved.

Sign in to view

jamesopstad self-requested a review July 20, 2026 10:15

jamesopstad reviewed Jul 20, 2026

View reviewed changes

jamesopstad approved these changes Jul 21, 2026

View reviewed changes

workers-devprod approved these changes Jul 21, 2026

View reviewed changes

github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jul 21, 2026

penalosa added 5 commits July 21, 2026 14:30

[remote-bindings] Add empty package

159c673

[remote-bindings] Extract remote binding implementation

0c64cf4

snapshot copy of DevEnv

ee6e6c3

remove obsolete inspector proxy

7f297eb

config pass through

4ca824d

penalosa and others added 21 commits July 21, 2026 14:30

packages

ebdb131

base move

c9f84a2

move more helpers

bcc6143

move retryOnApiFailure

39cbe42

move access

fb41427

copy ProxyWorekr

a3700e2

make proxycontroller green with minimal helpers

01b325e

reduction in more things we don't cara bout

1e0c276

make remote bindings package functional

d2dcd18

[remote-bindings] Remove dead dev runtime code

3806b52

[remote-bindings] Narrow remote runtime internals

920555b

[remote-bindings] Restore default account selection

b845d3a

chore: fix remote bindings lockfile

464b4b6

[remote-bindings] Collapse remote runtime controllers

448c24a

[remote-bindings] Embed workers for direct consumers

5bdef90

[remote-bindings] Fix direct consumer integration

4376590

[remote-bindings] Fix Windows worker embedding build

710e34f

[wrangler] Update invalid account error snapshot

fb1afc2

[remote-bindings] Prevent stale preview bindings

3ae2834

Update packages/remote-bindings/src/startDevWorker/RemoteRuntimeContr…

fe26a97

…oller.ts Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>

penalosa force-pushed the penalosa/manual-remote-bindings branch from 138abc1 to 79808aa Compare July 21, 2026 13:31

This comment was marked as resolved.

Sign in to view

penalosa force-pushed the penalosa/manual-remote-bindings branch from 79808aa to 2b3ea8b Compare July 21, 2026 14:21

penalosa merged commit 0df3d43 into main Jul 21, 2026
67 of 68 checks passed

penalosa deleted the penalosa/manual-remote-bindings branch July 21, 2026 14:46

github-project-automation Bot moved this from Approved to Done in workers-sdk Jul 21, 2026

workers-devprod mentioned this pull request Jul 21, 2026

Version Packages #14740

Merged

mack-erel mentioned this pull request Jul 22, 2026

[miniflare] Support connect() on remote VPC Network bindings in local dev #14712

Open

2 tasks

Uh oh!

Conversation

penalosa commented Jul 16, 2026

Uh oh!

changeset-bot Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ask-bonk Bot commented Jul 16, 2026

Uh oh!

ask-bonk Bot commented Jul 16, 2026

Uh oh!

workers-devprod commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

pkg-pr-new Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petebacondarwin commented Jul 20, 2026

Uh oh!

penalosa commented Jul 20, 2026

Uh oh!

workers-devprod left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

changeset-bot Bot commented Jul 16, 2026 •

edited

Loading

github-actions Bot commented Jul 16, 2026 •

edited

Loading

workers-devprod commented Jul 16, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 16, 2026 •

edited

Loading