[pp] Keep line accounting intact for multi-line object reprs#418
Open
bbatsov wants to merge 1 commit into
Open
[pp] Keep line accounting intact for multi-line object reprs#418bbatsov wants to merge 1 commit into
bbatsov wants to merge 1 commit into
Conversation
A value whose representation spans multiple lines (e.g. a custom print-method rendering a table) was written in one shot: the column counter absorbed the whole string, forcing everything after it into miser mode, and continuation lines lost their indentation. Write such representations line by line instead.
bbatsov
force-pushed
the
pp-multiline-object-reprs
branch
from
July 15, 2026 16:12
a2f54f8 to
0fa91a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A value whose representation spans multiple lines (e.g. a custom
print-methodrendering a table) was written to the count-keeping writer in one shot. The column counter absorbed the whole string, so everything after it on the parent form was forced into miser mode, and the continuation lines themselves lost their indentation. Writing such representations line by line fixes both.Split out of #417.