Tests: upstream read timeout tests. - #1
Open
climagabriel wants to merge 1 commit into
Open
Conversation
Partially read event pipe buffers are now flushed on read timeouts,
so the proxy_noclose.t no content length test finally passes. The
$SIG{__WARN__} redefinition was only needed for the "content-length
actually used" test, which succeeds since HTTP/1.1 support.
Claude-Session: https://claude.ai/code/session_01BERKTkJd6r3FPviAuD9SyE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for climagabriel/nginx PR: data already read from an upstream is flushed to the client on a read timeout. The four new timeout assertions fail on nginx 1.31.5 and pass with that PR; proxy_noclose.t and proxy_upgrade.t pass too.
When running as root, set
TEST_NGINX_GLOBALS='user root;'; otherwise the cache location returns 500 because the worker cannot open the cache path.https://claude.ai/code/session_01BERKTkJd6r3FPviAuD9SyE