Skip to content

fix(errors): accept unknown parameter type in parseTxError to safely handle null, string, and custom error objects #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yappermoar-boop wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(errors): accept unknown parameter type in parseTxError to safely handle null, string, and custom error objects #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions lib/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,21 @@
/**
* Parse raw blockchain/wallet errors into user-friendly messages.
*/
export function parseTxError(error: Error): { title: string; detail?: string } {
const msg = error.message || "";
export function parseTxError(error: unknown): { title: string; detail?: string } {
if (!error) {
return { title: "Transaction failed", detail: "An unknown error occurred." };
}

let msg = "";
if (typeof error === "string") {
msg = error;
} else if (error instanceof Error) {
msg = error.message || "";
} else if (typeof error === "object" && "message" in error && typeof (error as any).message === "string") {
msg = (error as any).message;
} else {
msg = String(error);
}

// User rejected the transaction in their wallet
if (
Expand Down