[Server] Log filesystem failures in FileSessionStore - #41
Closed
chr-hertel wants to merge 3 commits into
Closed
Conversation
…xtprotocol#483) Bumps [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) from 9.0.0 to 10.0.1. - [Release notes](https://github.com/astral-sh/setup-uv/releases) - [Commits](astral-sh/setup-uv@v9.0.0...v10.0.1) --- updated-dependencies: - dependency-name: astral-sh/setup-uv dependency-version: 10.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chr-hertel
force-pushed
the
fix/issue-23-filesession-logging
branch
from
August 29, 2026 08:30
01dca94 to
5c8d6dc
Compare
Owner
Author
|
Closed upstream by modelcontextprotocol#488 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileSessionStorenow takes an optional PSR-3 logger (defaulting toNullLogger, matching the SDK convention) and logs a warning when a filesystem operation fails in a way that loses data: failedmkdir, session file read/write/move failures, failed unlinks, andopendirfailure during GC. Benign race suppressions (e.g.filemtimeon a concurrently deleted file) keep their@.Closes #23
Note: expect a small merge overlap with the #24 PR, which also touches
gc()in this file — this change only adds a log line at the top ofgc(), so the conflict should be trivial.Confidence: 9/10 — mechanical change with targeted tests for read, write, and GC failure paths plus a happy-path silence check; permission-based tests skip gracefully when running as root.