feat(trace-viewer): add minimal Checkly ranged artifact support - #828
Draft
thebiglabasky wants to merge 2 commits into
Draft
feat(trace-viewer): add minimal Checkly ranged artifact support#828thebiglabasky wants to merge 2 commits into
thebiglabasky wants to merge 2 commits into
Conversation
|
@thebiglabasky is attempting to deploy a commit to the Checkly Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Manual Vercel preview is ready: https://playwright-trace-viewer-lxh8mhnnk-checkly.vercel.app (Checkly SSO protected). The Vercel PR check remains red only because the fork head requires GitHub authorization; the deployment itself completed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This draft targets
mainonly so the Checkly delta is reviewable and can receive a Vercel Preview. Do not merge it intomain.The intended deployment base is a new
checkly-nextbranch created atb4e7c87ce4c7f76ff1cf195d2d7d4565261ead10. Once a maintainer creates that branch, this PR should be retargeted tocheckly-next.What changed
rangeStart/rangeEndquery parameters at the UI boundary.Rangeheader.Why
Checkly stores multiple trace ZIPs as byte ranges within one signed aggregate object. The old production fork threads the range through several upstream layers and has drifted since July 2025. This implementation limits the Checkly production integration to two upstream call sites and one isolated helper.
Impact
The trace viewer gains current upstream improvements while preserving Checkly aggregate trace loading. Ordinary Playwright trace URLs are unchanged, and malformed range metadata fails closed before fetching the aggregate.
Validation
npx playwright test --config=tests/library/playwright.config.ts --project=chromium-library tests/library/unit/checklyTraceRange.spec.ts tests/library/trace-viewer-checkly.spec.ts— 13 passednpm run build— passedgit diff --check origin/main..HEAD— passed