ci: run create-checkly e2e jobs only for PRs that affect them [RED-934] - #1472
Merged
Conversation
The create-checkly e2e suite is slow enough to hold up the CI gates for PRs that never touch it. Add a second paths-filter step to the `changes` job (separate from the first because that one uses the `every` quantifier) exposing a `create-cli` output for the suite's inputs: packages/create-cli, the example templates it scaffolds from locally, the workspace-wide dependency/config files and the workflow itself. Gate both e2e jobs on that output. The jobs stay defined so the gates' `needs:` lists remain valid; a skipped job already counts as success. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: RED-934
The
create-checklye2e suite is slow enough to hold up the CI gates for PRs that never touch it. This scopes the twoe2e - create-checkly - *jobs to PRs that can actually affect the suite.changesjob gains a seconddorny/paths-filterstep exposing acreate-clioutput. It is a separate step because the existing one usespredicate-quantifier: every, whereas this filter needs the defaultsome(match any pattern).packages/create-cli/**,examples/**(the e2e runner pointsCHECKLY_E2E_LOCAL_TEMPLATE_ROOTat the checked-out templates), rootpackage.json,pnpm-lock.yaml,pnpm-workspace.yaml, and the workflow file itself.needs.changes.outputs.create-cliinstead ofcode. The jobs stay defined, so the gates'needs:lists are untouched and a skipped job continues to count as success.Known trade-off: any PR touching the shared
pnpm-lock.yaml(e.g. apackages/clidependency bump) still runs the suite, since a path filter cannot tell which workspace importer changed.Note: because the workflow file is in the filter, this PR itself runs the create-checkly jobs. The skip path is first exercised by the next unrelated PR after merge.
🤖 Generated with Claude Code