Skip to content

fix: preserve OpenAI OAuth prompt cache affinity #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2314860760 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve OpenAI OAuth prompt cache affinity #3800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/shared/providers/definitions/models/openai-responses.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,11 @@ function createModel(overrides: Partial<ConstructorParameters<typeof OpenAIRespo
}

describe('OpenAIResponses call settings', () => {
it('forces store=false for stateless responses while preserving user OpenAI provider options', () => {
it('forces store=false and uses the stable session ID as the prompt cache key for stateless responses', () => {
const openaiResponses = createModel({ forceStatelessResponses: true })

const settings = openaiResponses.exposeCallSettings({
sessionId: 'session-123',
providerOptions: {
openai: {
reasoningEffort: 'high',
Expand All @@ -69,6 +70,19 @@ describe('OpenAIResponses call settings', () => {
expect(settings.providerOptions).toEqual({
openai: {
reasoningEffort: 'high',
promptCacheKey: 'session-123',
store: false,
},
})
})

it('does not inject an empty prompt cache key when a stateless request has no session ID', () => {
const openaiResponses = createModel({ forceStatelessResponses: true })

const settings = openaiResponses.exposeCallSettings()

expect(settings.providerOptions).toEqual({
openai: {
store: false,
},
})
Expand Down
2 changes: 2 additions & 0 deletions src/shared/providers/definitions/models/openai-responses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export default class OpenAIResponses extends AbstractAISDKModel {

protected getCallSettings(options: CallChatCompletionOptions) {
const openaiProviderOptions = options.providerOptions?.openai
const promptCacheKey = this.options.forceStatelessResponses ? options.sessionId : undefined

return {
temperature: this.options.temperature,
Expand All @@ -54,6 +55,7 @@ export default class OpenAIResponses extends AbstractAISDKModel {
openai: {
...openaiProviderOptions,
...(this.options.forceStatelessResponses ? { store: false } : {}),
...(promptCacheKey ? { promptCacheKey } : {}),
},
}
: undefined,
Expand Down