Skip to content

fix(installer): avoid PromptScript failure for DSH - #97

Merged
lxcong merged 1 commit into
chainbase-labs:mainfrom
zzAllenn:codex/fix-dsh-global-skill-install
Aug 24, 2026
Merged

fix(installer): avoid PromptScript failure for DSH#97
lxcong merged 1 commit into
chainbase-labs:mainfrom
zzAllenn:codex/fix-dsh-global-skill-install

Conversation

@zzAllenn

Copy link
Copy Markdown
Contributor

Summary

  • install the AgentKey Skill through the Skills CLI universal target for DSH-only installs
  • avoid passing either dsh or the unsupported global PromptScript target while preserving explicit mixed-agent targets
  • update Bash, PowerShell, English/Chinese setup guidance, retry instructions, and release-asset source docs
  • add Bash mixed-target coverage and a Windows PowerShell invocation regression

Root cause

skills@1.5.23 -g -y adds PromptScript to its universal target set even though PromptScript has no global install directory. The canonical AgentKey Skill still installs, but the command prints Failed to install 1. Explicitly targeting universal writes the same ~/.agents/skills/agentkey copy without selecting PromptScript.

Validation

  • bats tests/ — 42/42
  • bash -n scripts/install.sh
  • bash -n scripts/uninstall.sh
  • bash -n scripts/build-release-assets.sh
  • scripts/build-release-assets.sh with an isolated output directory
  • workflow YAML parse
  • git diff --check
  • Windows behavior regression added to the windows-latest Scripts tests job

Deployment follow-up

Merging/releasing this PR does not automatically update agentkey.app/install.sh. After release, publish the current Bash/PowerShell install and uninstall scripts to the website origin and purge the CDN; the live endpoints were serving stale pre-DSH content during verification.

@lxcong
lxcong merged commit 8e93c67 into chainbase-labs:main Aug 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants