builder-reimage: take the node offline before syncing labels - #2697
Merged
Conversation
The Sync Labels stage ran while the node was still online, three stages before Prepare Jenkins Node marked it offline for the reimage. A newly synced label can instantly attract queued builds: when the windows label was restored to adami10 today, all four queued ceph-dev-build windows cells landed on the node in the seconds before the reimage wiped it, and failed on the stale pre-reimage disk state. Move Prepare Jenkins Node ahead of Sync Labels so the node is already offline when new labels appear. prepare_for_reimage only needs the node name and skips cleanly when the node does not exist yet, so it is safe to run first; Detect OS reads the inventory file, not the live node. Signed-off-by: David Galloway <david.galloway@ibm.com> Assisted-by: Claude Fable 5 (claude-fable-5)
jitendrasahu1803
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the ceph-dev-build windows saga: the reimage of adami10 today did work, but the Sync Labels stage runs three stages before Prepare Jenkins Node marks the node offline. The moment
sync_labels.pyrestored thewindowslabel, Jenkins dispatched all four queued windows cells onto the still-online, still-dirty node — each failed in ~0.6s on the pre-reimage disk state, seconds before FOG wiped it.Reorder so the node is marked temporarily offline before labels are synced.
prepare_for_reimageis self-contained (needs only the node name, exits 0 if the node doesn't exist) and Detect OS reads the inventory file rather than the live node, so the reorder has no other effects.SKIP_REIMAGE=truelabel-only syncs behave exactly as before.