Skip to content

enh(storage::dell::me4::restapi): Add tier distribution and page allocation metrics to volume-statistics mode #6292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JackTor wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

enh(storage::dell::me4::restapi): Add tier distribution and page allocation metrics to volume-statistics mode #6292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 53 additions & 3 deletions src/storage/dell/me4/restapi/mode/volumestatistics.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ use Digest::MD5 qw(md5_hex);

sub prefix_output {
my ($self, %options) = @_;

return "Volume '" . $options{instance_value}->{display} . "' ";
}

Expand Down Expand Up @@ -130,6 +130,54 @@ sub set_counters {
{ template => '%s', min => 0, label_extra_instance => 1 }
]
}
},
{ label => 'tier-ssd-percent', nlabel => 'volume.tier.ssd.percentage', set => {
key_values => [ { name => 'percent-tier-ssd' } ],
output_template => 'tier SSD: %s%%',
perfdatas => [
{ template => '%d', min => 0, max => 100, label_extra_instance => 1 }
]
}
},
{ label => 'tier-sata-percent', nlabel => 'volume.tier.archive.percentage', set => {
key_values => [ { name => 'percent-tier-sata' } ],
output_template => 'tier Archive (SATA): %s%%',
perfdatas => [
{ template => '%d', min => 0, max => 100, label_extra_instance => 1 }
]
}
},
{ label => 'tier-sas-percent', nlabel => 'volume.tier.sas.percentage', set => {
key_values => [ { name => 'percent-tier-sas' } ],
output_template => 'tier SAS: %s%%',
perfdatas => [
{ template => '%d', min => 0, max => 100, label_extra_instance => 1 }
]
}
},
{ label => 'tier-rfc-percent', nlabel => 'volume.tier.rfc.percentage', set => {
key_values => [ { name => 'percent-allocated-rfc' } ],
output_template => 'tier RFC: %s%%',
perfdatas => [
{ template => '%d', min => 0, max => 100, label_extra_instance => 1 }
]
}
},
{ label => 'pages-alloc', nlabel => 'volume.pages.allocated.perminute', set => {
key_values => [ { name => 'pages-alloc-per-minute' } ],
output_template => 'pages alloc/min: %s',
perfdatas => [
{ template => '%d', min => 0, label_extra_instance => 1 }
]
}
},
{ label => 'pages-dealloc', nlabel => 'volume.pages.deallocated.perminute', set => {
key_values => [ { name => 'pages-dealloc-per-minute' } ],
output_template => 'pages dealloc/min: %s',
perfdatas => [
{ template => '%d', min => 0, label_extra_instance => 1 }
]
}
}
];
}
Expand All @@ -155,7 +203,7 @@ sub manage_selection {
foreach my $volume (@{$results->{'volume-statistics'}}) {
next if (defined($self->{option_results}->{filter_name}) && $self->{option_results}->{filter_name} ne ''
&& $volume->{'volume-name'} !~ /$self->{option_results}->{filter_name}/);

$self->{volumes}->{$volume->{'volume-name'}} = { display => $volume->{'volume-name'}, %{$volume} };
}

Expand Down Expand Up @@ -191,7 +239,9 @@ Can be: 'data-read', 'data-written',
'reads', 'writes',
'data-transfer', 'iops',
'write-cache-percent', 'write-cache-hits', 'write-cache-misses',
'read-cache-hits', 'read-cache-misses'.
'read-cache-hits', 'read-cache-misses',
'tier-ssd-percent', 'tier-sata-percent', 'tier-sas-percent',
'tier-rfc-percent', 'pages-alloc', 'pages-dealloc'.

=back

Expand Down