Skip to content

Move RNG advance with Ranluxpp to its own kernel - #2576

Open
davidsgr wants to merge 6 commits into
celeritas-project:developfrom
davidsgr:add_rng_advance_kernel
Open

davidsgr wants to merge 6 commits into
celeritas-project:developfrom
davidsgr:add_rng_advance_kernel

Conversation

@davidsgr

@davidsgr davidsgr commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

When performing Rayleigh scattering, a potentially large number of random numbers are required. Previously, capability was added to pre-allocate a block of random bits when using the Ranluxpp RNG. This PR updates that capability to make the pre-allocation an on-device kernel.

@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.48%. Comparing base (0ac2b62) to head (1544a2b).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2576      +/-   ##
===========================================
- Coverage    87.08%   85.48%   -1.61%     
===========================================
  Files         1420     1387      -33     
  Lines        45968    44254    -1714     
  Branches     14517    11418    -3099     
===========================================
- Hits         40031    37830    -2201     
+ Misses        4789     4681     -108     
- Partials      1148     1743     +595     
Files with missing lines Coverage Δ
...celeritas/optical/interactor/RayleighInteractor.hh 100.00% <ø> (ø)
src/celeritas/optical/model/RayleighExecutor.hh 100.00% <ø> (ø)
src/celeritas/optical/model/RayleighModel.cc 88.37% <ø> (-0.27%) ⬇️

... and 780 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidsgr
davidsgr marked this pull request as draft October 22, 2026 18:09
@davidsgr
davidsgr force-pushed the add_rng_advance_kernel branch from ee310c9 to 76fcb1c Compare October 22, 2026 18:31
@davidsgr

Copy link
Copy Markdown
Contributor Author

@sethrj 1) Take a look at this and see if I did this right, 2) Not sure how to add unit tests for this, or whether unit tests are needed

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Test summary

 6 106 files  10 079 suites   7m 22s ⏱️
 1 955 tests  1 940 ✅  15 💤 0 ❌
34 216 runs  33 986 ✅ 230 💤 0 ❌

Results for commit 1bebd27.

♻️ This comment has been updated with latest results.

@davidsgr davidsgr self-assigned this Oct 26, 2026
@davidsgr
davidsgr requested a review from sethrj October 26, 2026 16:34
@davidsgr davidsgr added the enhancement New feature or request label Oct 26, 2026
@davidsgr
davidsgr marked this pull request as ready for review October 26, 2026 16:35
@davidsgr davidsgr changed the title draft: Move RNG advance with Ranluxpp to its own kernel Move RNG advance with Ranluxpp to its own kernel Oct 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant