Skip to content

Improve consistency and documentation of assertion macros - #2553

Draft
sethrj wants to merge 7 commits into
celeritas-project:developfrom
sethrj:assert
Draft

Improve consistency and documentation of assertion macros#2553
sethrj wants to merge 7 commits into
celeritas-project:developfrom
sethrj:assert

Conversation

@sethrj

@sethrj sethrj commented Oct 11, 2026

Copy link
Copy Markdown
Member

Follows discussion from #2547

  • Use celeritas::unreachable instead of CELERITAS_UNREACHABLE
  • Consistently dispatch to implementation macros
  • Move MPI runtime macros to MPI-only code
  • Move device runtime macros to DeviceRutimeApi.hh
  • Differentiate NVCC-ndebug and HIP device runtime macros
assert

@sethrj sethrj added documentation Documentation and examples core Software engineering infrastructure (corecel) labels Oct 11, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrguilima mrguilima Awaiting requested review from mrguilima mrguilima will be requested when the pull request is marked ready for review mrguilima is a code owner
@esseivaju esseivaju Awaiting requested review from esseivaju esseivaju will be requested when the pull request is marked ready for review esseivaju is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

core Software engineering infrastructure (corecel) documentation Documentation and examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sethrj