Normalize cel/prompt_test.go to LF, add missing newline in prompt.go#1361
Merged
Conversation
cel-expr#1359 converted cel/prompt.go to LF line endings but left the file without a trailing final newline (not gofmt-clean), and left the CRLF line endings in cel/prompt_test.go in place. Fix both, and add a .gitattributes that normalizes text files to LF so CRLF cannot ship in a release again (see kubernetes/kubernetes#140205 for the downstream impact of CRLF in the v0.29.0 module zip). Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
changed the title
Collaborator
|
/gcbrun |
l46kok
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1359, which converted cel/prompt.go to LF but left two loose ends from #1311:
Fix both, and add a
.gitattributes(* text=auto eol=lf) so CRLF cannot ship in a release again — kubernetes/kubernetes#140205 shows the downstream impact when it does: projects that enforce LF via .gitattributes cannot vendor the module byte-for-byte, so their vendor verification fails permanently. (v0.29.1 already unblocks Kubernetes; this PR is the remaining cleanup plus prevention.)Content is otherwise unchanged: apart from the new .gitattributes,
git diff --ignore-cr-at-eol upstream/mastershows only the added trailing newline.