Adding additional Support for the Flexvm - #16222
Open
123-komal wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring per-selection boot disk types for Dataproc Flex VMs, allowing mixed machine generations (such as e2 and n4) that require different boot disk types to be used together. It adds configuration parsing, validation, and serialization logic, utilizing an unknown field workaround for the generated Java client's lack of a disk config setter. Feedback on the changes suggests simplifying DataprocConf.getDiskTypeList by removing a redundant empty list check.
123-komal
force-pushed
the
flexvm-support
branch
from
September 14, 2026 06:41
4e30b0a to
3cfca9b
Compare
updated updated
123-komal
force-pushed
the
flexvm-support
branch
from
September 14, 2026 07:01
3cfca9b to
13b352d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.