Skip to content

Update module github.com/docker/docker to v28 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update module github.com/docker/docker to v28 #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require (
github.com/containerd/containerd/v2 v2.2.5

@kimchi-review kimchi-review Bot Jul 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️🔧 Maintainability

This PR performs a major version upgrade of the direct dependency github.com/docker/docker from v27.5.1+incompatible to v28.5.2+incompatible without any accompanying source code or test changes. Docker v28 can introduce breaking API changes compared to v27, and without verifying usage sites, the project may fail to compile or behave incorrectly at runtime.

💡 Suggestion: Confirm that all usages of github.com/docker/docker client types and methods in the codebase are compatible with v28. Run go build ./... and the full test suite. If the upgrade passes, add or update an integration/unit test that exercises Docker client code paths to catch future regressions.

github.com/containerd/platforms v1.0.0-rc.2
github.com/distribution/reference v0.6.0
github.com/docker/docker v27.5.1+incompatible
github.com/docker/docker v28.5.2+incompatible

@kimchi-review kimchi-review Bot Jul 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️🧪 Testing

Because github.com/docker/docker is a direct require dependency used for image analysis, a major version bump warrants targeted test coverage. The PR provides no evidence that the upgraded dependency has been exercised in CI or that Docker-specific code paths still pass.

💡 Suggestion: Ensure CI runs go test ./... after go mod tidy, and consider adding a test that invokes the Docker client code paths affected by this upgrade (e.g., image pull, inspect, or registry interaction) before merging.

github.com/docker/go-connections v0.5.0
github.com/google/go-containerregistry v0.20.3
github.com/opencontainers/go-digest v1.0.0
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,6 +930,8 @@ github.com/docker/distribution v2.8.3+incompatible h1:AtKxIZ36LoNK51+Z6RpzLpddBi
github.com/docker/distribution v2.8.3+incompatible/go.mod h1:J2gT2udsDAN96Uj4KfcMRqY0/ypR+oyYUYmja8H+y+w=
github.com/docker/docker v27.5.1+incompatible h1:4PYU5dnBYqRQi0294d1FBECqT9ECWeQAIfE8q4YnPY8=
github.com/docker/docker v27.5.1+incompatible/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
github.com/docker/docker v28.5.2+incompatible h1:DBX0Y0zAjZbSrm1uzOkdr1onVghKaftjlSWt4AFexzM=
github.com/docker/docker v28.5.2+incompatible/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
github.com/docker/docker-credential-helpers v0.8.2 h1:bX3YxiGzFP5sOXWc3bTPEXdEaZSeVMrFgOr3T+zrFAo=
github.com/docker/docker-credential-helpers v0.8.2/go.mod h1:P3ci7E3lwkZg6XiHdRKft1KckHiO9a2rNtyFbZ/ry9M=
github.com/docker/go-connections v0.5.0 h1:USnMq7hx7gwdVZq1L49hLXaFtUdTADjXGp+uj1Br63c=
Expand Down
Loading