Repository navigation
Restrict HTTP debug logging to safe request metadata - #809
Open
sameerforge wants to merge 1 commit into
Open
sameerforge wants to merge 1 commit into
sameerforge wants to merge 1 commit into
Conversation
Replace raw HTTP request and response dumps with method, sanitized endpoint and status metadata. Omit headers, bodies and raw transport error text from diagnostics without changing authentication or response data. Add tests for URL credentials, cookies, response cookies and transport failures. Signed-off-by: Sameer Khan <sameer.khan@broadcom.com>
sameerforge
force-pushed
the
topic/sameerkh/upstream-audit-fixes-20261022
branch
from
October 22, 2026 05:56
23e58ca to
5296434
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Replace raw HTTP request/response dumps with method, sanitized endpoint and status metadata. Omit URL credentials and query values, headers, bodies and raw transport error text from debug output. Preserve the original requests, authentication headers, response cookies and response bodies.
Validation
go test ./pkg/imgpkg/registry/...golangci-lint rungo test ./pkg/...reaches existing registry integration tests that requireIMGPKG_E2E_IMAGEandIMGPKG_E2E_RELOCATION_REPO; those environments were not configured for this run.developand its existing regression tests pass.CI coverage
Does this PR introduce a user-facing change?