Skip to content

carbon-core: mark x64-linux as supported - #129

Open
LelandJin wants to merge 1 commit into
carbonengine:mainfrom
LelandJin:carbon-core-linux-supports
Open

carbon-core: mark x64-linux as supported#129
LelandJin wants to merge 1 commit into
carbonengine:mainfrom
LelandJin:carbon-core-linux-supports

Conversation

@LelandJin

Copy link
Copy Markdown

Summary

Marks carbon-core as supported on x64-linux, split out of #127 per review feedback to avoid a circular dependency between the toolchain/triplet PR and the core changes.

"supports": "(windows & x64) | osx | (linux & x64)"

Dependencies / merge order

  1. Add x64-linux triplets and toolchains #127x64-linux triplets and toolchains
  2. Add Linux (x64) support: presets and POSIX port core#31 — Linux presets and POSIX port of carbon core (validated: full test suite passes on Fedora 43 / GCC 15)
  3. this PR (plus a version/REF bump of the port once a core release containing Update CMAKE_OSX_DEPLOYMENT_TARGET to 11.0 in toolchains #31 exists)

The umbrella carbon port is intentionally left unchanged — most of its components have no Linux port yet.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a416802db0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ports/carbon-core/vcpkg.json
@LelandJin
LelandJin force-pushed the carbon-core-linux-supports branch from a416802 to cccb47a Compare July 16, 2026 11:08
Split out of the x64-linux triplets PR per review feedback, rebased onto the carbon-core 3.0.0 update. Bumps port-version to 1 and publishes the new port tree to the version database so git-registry consumers pick up the change. Depends on the x64-linux triplets/toolchains and on the Linux port of carbon core (carbonengine/core#31).
@LelandJin
LelandJin force-pushed the carbon-core-linux-supports branch from cccb47a to 96908be Compare July 16, 2026 11:11
@ccpgames-carbon

ccpgames-carbon commented Jul 20, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants