Skip to content

fix: check field type via C++ schema in from_dict to avoid a reference create #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haata merged 1 commit into from
Sep 22, 2026
Merged

fix: check field type via C++ schema in from_dict to avoid a reference create #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion capnp/includes/capnp_cpp.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ cdef extern from "capnp/schema.h" namespace " ::capnp":
cbool isEnum()
cbool isStruct()
cbool isInterface()
cbool isData()

StructSchema asStruct() except +reraise_kj_exception
EnumSchema asEnum() except +reraise_kj_exception
Expand Down Expand Up @@ -185,7 +186,7 @@ cdef extern from "capnp/schema.h" namespace " ::capnp":
FieldSubset getUnionFields()
FieldSubset getNonUnionFields()

Field getFieldByName(char * name)
Field getFieldByName(char * name) except +reraise_kj_exception

cbool operator == (StructSchema)

Expand Down
5 changes: 2 additions & 3 deletions capnp/lib/capnp.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1879,9 +1879,8 @@ cdef class _DynamicStructBuilder:
for key, val in d.iteritems():
if key != 'which':
if isinstance(val, str):
field = self.schema.fields.get(key)
dtype = field.proto.slot.type.which()
if dtype == "data":
key_bytes = key.encode()
if self.thisptr.getSchema().getFieldByName(key_bytes).getType().isData():
# decode bytes from utf-8 base64 encoding
val = base64.b64decode(val)
try:
Expand Down
Loading