Skip to content

feat: add Electron app version constraint flags for live update bundles #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robingenz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add Electron app version constraint flags for live update bundles #185

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94ddefd
feat: add Electron app version constraint flags for live update bundles
robingenz Jul 13, 2026
b9b2560
test: add Electron version constraint pass-through tests
robingenz Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/commands/apps/bundles/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,18 @@ export default defineCommand({
.describe(
'A custom property to assign to the bundle. Must be in the format `key=value`. Can be specified multiple times.',
),
electronMax: z
.string()
.optional()
.describe('The maximum Electron app version (`app.getVersion()`) that the bundle supports.'),
electronMin: z
.string()
.optional()
.describe('The minimum Electron app version (`app.getVersion()`) that the bundle supports.'),
electronEq: z
.string()
.optional()
.describe('The exact Electron app version (`app.getVersion()`) that the bundle does not support.'),
expiresInDays: z.coerce
.number({
message: 'Expiration days must be an integer.',
Expand Down
12 changes: 12 additions & 0 deletions src/commands/apps/bundles/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,18 @@ export default defineCommand({
})
.optional()
.describe('The percentage of devices to deploy the bundle to. Must be a number between 0 and 1 (e.g. 0.5).'),
electronMax: z
.string()
.optional()
.describe('The maximum Electron app version (`app.getVersion()`) that the bundle supports.'),
electronMin: z
.string()
.optional()
.describe('The minimum Electron app version (`app.getVersion()`) that the bundle supports.'),
electronEq: z
.string()
.optional()
.describe('The exact Electron app version (`app.getVersion()`) that the bundle should not support.'),
iosMax: z
.string()
.optional()
Expand Down
18 changes: 18 additions & 0 deletions src/commands/apps/liveupdates/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,18 @@ export default defineCommand({
.describe(
'A custom property to assign to the bundle. Must be in the format `key=value`. Can be specified multiple times.',
),
electronMax: z
.string()
.optional()
.describe('The maximum Electron app version (`app.getVersion()`) that the bundle supports.'),
electronMin: z
Comment thread
robingenz marked this conversation as resolved.
.string()
.optional()
.describe('The minimum Electron app version (`app.getVersion()`) that the bundle supports.'),
electronEq: z
.string()
.optional()
.describe('The exact Electron app version (`app.getVersion()`) that the bundle does not support.'),
expiresInDays: z.coerce
.number({
message: 'Expiration days must be an integer.',
Expand Down Expand Up @@ -122,6 +134,9 @@ export default defineCommand({
commitRef,
commitSha,
customProperty,
electronEq,
electronMax,
electronMin,
expiresInDays,
gitRef,
iosEq,
Expand Down Expand Up @@ -268,6 +283,7 @@ export default defineCommand({
channelName: channel,
checksum,
eqAndroidAppVersionCode: androidEq,
eqElectronAppVersionCode: electronEq,
eqIosAppVersionCode: iosEq,
gitCommitMessage: commitMessage,
gitCommitRef: commitRef,
Expand All @@ -276,8 +292,10 @@ export default defineCommand({
customProperties: parseCustomProperties(customProperty),
url,
maxAndroidAppVersionCode: androidMax,
maxElectronAppVersionCode: electronMax,
maxIosAppVersionCode: iosMax,
minAndroidAppVersionCode: androidMin,
minElectronAppVersionCode: electronMin,
minIosAppVersionCode: iosMin,
rolloutPercentage: (rolloutPercentage ?? 100) / 100,
signature,
Expand Down
18 changes: 18 additions & 0 deletions src/commands/apps/liveupdates/upload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,18 @@ export default defineCommand({
.describe(
'A custom property to assign to the bundle. Must be in the format `key=value`. Can be specified multiple times.',
),
electronMax: z
.string()
.optional()
.describe('The maximum Electron app version (`app.getVersion()`) that the bundle supports.'),
electronMin: z
Comment thread
robingenz marked this conversation as resolved.
.string()
.optional()
.describe('The minimum Electron app version (`app.getVersion()`) that the bundle supports.'),
electronEq: z
.string()
.optional()
.describe('The exact Electron app version (`app.getVersion()`) that the bundle does not support.'),
expiresInDays: z.coerce
.number({
message: 'Expiration days must be an integer.',
Expand Down Expand Up @@ -148,6 +160,9 @@ export default defineCommand({
commitRef,
commitSha,
customProperty,
electronEq,
electronMax,
electronMin,
expiresInDays,
gitRef,
iosEq,
Expand Down Expand Up @@ -311,15 +326,18 @@ export default defineCommand({
artifactType,
channelName: channel,
eqAndroidAppVersionCode: androidEq,
eqElectronAppVersionCode: electronEq,
eqIosAppVersionCode: iosEq,
gitCommitMessage: commitMessage,
gitCommitRef: commitRef,
gitCommitSha: commitSha,
gitRef,
customProperties: parseCustomProperties(customProperty),
maxAndroidAppVersionCode: androidMax,
maxElectronAppVersionCode: electronMax,
maxIosAppVersionCode: iosMax,
minAndroidAppVersionCode: androidMin,
minElectronAppVersionCode: electronMin,
minIosAppVersionCode: iosMin,
// Convert percentage from 0-100 to 0-1 for API
rolloutPercentage: (rolloutPercentage ?? 100) / 100,
Expand Down
6 changes: 6 additions & 0 deletions src/types/app-bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export interface CreateAppBundleDto {
channelName?: string;
checksum?: string;
eqAndroidAppVersionCode?: string;
eqElectronAppVersionCode?: string;
eqIosAppVersionCode?: string;
gitCommitMessage?: string;
gitCommitRef?: string;
Expand All @@ -19,8 +20,10 @@ export interface CreateAppBundleDto {
expiresAt?: string;
url?: string;
maxAndroidAppVersionCode?: string;
maxElectronAppVersionCode?: string;
maxIosAppVersionCode?: string;
minAndroidAppVersionCode?: string;
minElectronAppVersionCode?: string;
minIosAppVersionCode?: string;
rolloutPercentage?: number;
signature?: string;
Expand All @@ -37,10 +40,13 @@ export interface UpdateAppBundleDto {
appId: string;
artifactStatus?: 'pending' | 'ready';
maxAndroidAppVersionCode?: string;
maxElectronAppVersionCode?: string;
maxIosAppVersionCode?: string;
minAndroidAppVersionCode?: string;
minElectronAppVersionCode?: string;
minIosAppVersionCode?: string;
eqAndroidAppVersionCode?: string;
eqElectronAppVersionCode?: string;
eqIosAppVersionCode?: string;
rolloutPercentage?: number;
}
Loading