fix(coding-agent): hide marketplace temp clone paths#4704
Open
roboomp wants to merge 1 commit into
Open
Conversation
Displayed cloned marketplace catalog validation errors with repository-relative catalog paths and the original source identifier. Fixes #4702
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Collaborator
Author
|
No code changes made: the Codex review failure is a repository/account quota issue, not a PR defect. Repo admins need to enable/add credits for Codex code reviews in the linked settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro
A malformed cloned marketplace catalog missing
ownerreproduced the reported failure withbun test /tmp/repro-4702-temp-clone-path.test.ts: before the fix, the error included.tmp-clone-*in the catalog path instead of only.claude-plugin/marketplace.jsonplus the requested source.Cause
packages/coding-agent/src/extensibility/plugins/marketplace/fetcher.tsread cloned catalogs throughreadMarketplaceCatalog(tmpDir)and passed the absolute temporarycatalogPathintoparseMarketplaceCatalog;cloneAndReadCatalogthen wrapped that validation error with the clone URL but kept the absolute temp path and had no originalowner/reposource string to append.Fix
.omp-plugin/marketplace.jsonor.claude-plugin/marketplace.json, not.tmp-clone-*paths.cloneAndReadCatalogand append it to cloned repository errors.Verification
bun test /tmp/repro-4702-temp-clone-path.test.tsnow passes with no.tmp-clone-*leak.bun test packages/coding-agent/test/marketplace/fetcher.test.tspassed: 27 pass, 3 skip, 0 fail. Pre-publish gate passed duringgh_push_branch/gh_open_pr. Fixes #4702