Skip to content

fix(coding-agent): hide marketplace temp clone paths#4704

Open
roboomp wants to merge 1 commit into
mainfrom
farm/83425296/marketplace-temp-clone-path
Open

fix(coding-agent): hide marketplace temp clone paths#4704
roboomp wants to merge 1 commit into
mainfrom
farm/83425296/marketplace-temp-clone-path

Conversation

@roboomp

@roboomp roboomp commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Repro

A malformed cloned marketplace catalog missing owner reproduced the reported failure with bun test /tmp/repro-4702-temp-clone-path.test.ts: before the fix, the error included .tmp-clone-* in the catalog path instead of only .claude-plugin/marketplace.json plus the requested source.

Cause

packages/coding-agent/src/extensibility/plugins/marketplace/fetcher.ts read cloned catalogs through readMarketplaceCatalog(tmpDir) and passed the absolute temporary catalogPath into parseMarketplaceCatalog; cloneAndReadCatalog then wrapped that validation error with the clone URL but kept the absolute temp path and had no original owner/repo source string to append.

Fix

  • Keep marketplace catalog lookup paths as repository-relative display strings while resolving them against the filesystem root for reads.
  • Pass relative display paths into cloned catalog validation so parse errors name .omp-plugin/marketplace.json or .claude-plugin/marketplace.json, not .tmp-clone-* paths.
  • Thread the original marketplace source through cloneAndReadCatalog and append it to cloned repository errors.
  • Add regression coverage for malformed cloned catalog validation errors.

Verification

bun test /tmp/repro-4702-temp-clone-path.test.ts now passes with no .tmp-clone-* leak. bun test packages/coding-agent/test/marketplace/fetcher.test.ts passed: 27 pass, 3 skip, 0 fail. Pre-publish gate passed during gh_push_branch/gh_open_pr. Fixes #4702

Displayed cloned marketplace catalog validation errors with repository-relative catalog paths and the original source identifier.

Fixes #4702
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@roboomp

roboomp commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

No code changes made: the Codex review failure is a repository/account quota issue, not a PR defect. Repo admins need to enable/add credits for Codex code reviews in the linked settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouched Passed the vouch gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marketplace add error shows temp clone path instead of source URL

1 participant