Skip to content

fix(tui): dispose stale session UI renderers#4693

Merged
can1357 merged 1 commit into
mainfrom
farm/5b16a1c0/tui-new-chat-flicker
Jul 8, 2026
Merged

fix(tui): dispose stale session UI renderers#4693
can1357 merged 1 commit into
mainfrom
farm/5b16a1c0/tui-new-chat-flicker

Conversation

@roboomp

@roboomp roboomp commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Repro

Starting a replacement chat after a prior session can leave transient TUI components detached but alive. I reproduced the render loop with bun .wt/repro-4686.js: after a status Loader was removed with Container.clear(), it still called requestComponentRender() (before=3, after=5) and exited with code 1. I also checked the reporter's resize follow-up with bun test packages/tui/test/resize-viewport-defer.test.ts packages/tui/test/issue-2088-repro.test.ts packages/tui/test/issue-2095-repro.test.ts, which kept the existing resize renderer regressions green.

Cause

Container.clear() in packages/tui/src/tui.ts only detaches children; it does not call child dispose() hooks. New-session and session-switch UI paths in packages/coding-agent/src/modes/controllers/*, interactive-mode.ts, and ui-helpers.ts used clear() for destructive transcript/status replacement, so active Loader/transcript components could keep timers alive and continue requesting TUI renders after the new chat or resize redraw started.

Fix

  • Added Container.disposeChildren() in packages/tui/src/tui.ts for the common destructive-clear contract: dispose every child, then detach it.
  • Routed new-session, handoff, extension/session-switch, transient status, and pending-message replacement paths through clearTransientSessionUi(), resetTranscript(), renderInitialMessages(), or disposeChildren() instead of non-disposing clears.
  • Removed redundant pre-rebuild transcript clears so renderInitialMessages() can dispose the old transcript blocks itself.
  • Added TUI regression coverage for disposeChildren() and for detached loader repaint timers stopping when a container is destructively cleared.

Verification

  • bun test packages/tui/test/container-dispose.test.ts packages/tui/test/loader.test.ts → 11 pass, 0 fail.
  • bun --cwd=packages/tui run check → passed.
  • bun --cwd=packages/coding-agent run check:types → passed.
  • bun --cwd=packages/coding-agent run check → passed.
  • bun test packages/tui/test/resize-viewport-defer.test.ts packages/tui/test/issue-2088-repro.test.ts packages/tui/test/issue-2095-repro.test.ts → 26 pass, 0 fail.
  • bun run fix → passed before commit.

Fixes #4686

Stopped new-session and session-switch UI paths from detaching active loader/render components without running their disposal hooks.

Added container and loader coverage for disposing children before destructive transcript/status replacement.

Fixes #4686
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@github-actions github-actions Bot added the vouched Passed the vouch gate label Jul 6, 2026
@roboomp

roboomp commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

No code change requested by this notice. PR #4693 remains ready for maintainer review; Codex review quota needs repo-admin action outside this branch.

@can1357 can1357 merged commit ba7a8fc into main Jul 8, 2026
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouched Passed the vouch gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tui flickering after every new chat

2 participants