feat(coding-agent): allow thinking renderers to replace blocks#4669
Open
shoucandanghehe wants to merge 1 commit into
Open
feat(coding-agent): allow thinking renderers to replace blocks#4669shoucandanghehe wants to merge 1 commit into
shoucandanghehe wants to merge 1 commit into
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
roboomp
reviewed
Jul 6, 2026
roboomp
left a comment
Collaborator
There was a problem hiding this comment.
P2: coherent implementation of the #1728 extension API shape, but it expands a public rendering contract, so this still needs the maintainer’s explicit merge call.
One should-fix: the packages/coding-agent/CHANGELOG.md entry is under released 15.11.3 instead of ## [Unreleased].
Verified locally: focused component tests passed (60 pass), bun --cwd=packages/coding-agent run check:types passed, and check:docs passed. Thanks for rerolling this against current main.
0cff7d7 to
5882cdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rerolls the assistant thinking renderer replacement API for #1728 against current
main.Thinking renderers now support:
Component: legacy append behavior below the default thinking Markdown.{ type: "append", component }: explicit append behavior.{ type: "replace", component }: suppresses the default thinking Markdown for that thinking block and renders the replacement component instead.Details
requestRender()semantics for both mounted async components and lateundefined-> append/replace renderer output.Verification
bun test packages/coding-agent/test/modes/components/transcript-container.test.ts packages/coding-agent/test/modes/components/assistant-message-mermaid.test.ts bun --cwd=packages/coding-agent run check:types bun --cwd=packages/coding-agent run check:docsResults:
60 pass,0 fail,182 expect() callscheck:typespassedcheck:docspassed (Docs index fresh for 121 docs)Closes #1728.
Previous stale PR: #2340.