Update the value-Case fan-out's prose to the DisjointJoin it builds - #75
Merged
Conversation
Contributor
Author
This was referenced Aug 11, 2026
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 11, 2026 22:34
d97ecfc to
e797e30
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 12, 2026 00:09
e797e30 to
ab3b01c
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 12, 2026 00:38
ab3b01c to
87987ce
Compare
dpmills
marked this pull request as ready for review
August 12, 2026 03:21
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 12, 2026 20:08
87987ce to
7d00832
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 12, 2026 20:42
7d00832 to
eea8c58
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 12, 2026 22:30
eea8c58 to
a9d9d6d
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 12, 2026 22:45
a9d9d6d to
fb63833
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 13, 2026 05:39
fb63833 to
70e744b
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 13, 2026 06:01
70e744b to
0e93344
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 13, 2026 19:18
0e93344 to
677103e
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 13, 2026 23:42
677103e to
0a9a39d
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 14, 2026 19:49
0a9a39d to
f977425
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 14, 2026 21:34
f977425 to
c52705f
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 14, 2026 21:41
c52705f to
b835b47
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 14, 2026 23:11
b835b47 to
e3f3d20
Compare
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 17, 2026 17:57
e3f3d20 to
f00629f
Compare
sortalongo
approved these changes
Aug 17, 2026
sortalongo
left a comment
Contributor
There was a problem hiding this comment.
Can you do a redundant-jargon pass? There are a few terms that I hadn't seen before cropping up here that I'm not sure deserve coining (grounded subtyping, gate, bridge, chain).
Splitting `CollectionUnion` into `Copair` and `DisjointJoin` (#86) deleted `is_index_partition_of` and the subtyping arm that reconciled a `Variant`-domain fan-out against a plain-domain demand. Three prose sites still describe that mechanism. They are comments, so the suite stays green while asserting requirements on code that no longer exists, and `doc_refs` cannot see them: it validates doc paths and headings, not identifiers named in comments. `tests/compilation_pipeline/conditionals.rs` twice told the reader the fan-out's tagged-`Variant` domain reconciles against the arms' joined data function by `is_index_partition_of`, once as a requirement that function "must accept". Both now say what the fan-out builds: a `DisjointJoin` over the one domain the arms share, each leg restricted by its own gate. `mutability.md`'s data-typed-selection bullet claimed the same collapse as one of two reconciliation paths. It now states the join landing on the shared domain, and keeps the Σ path for arms at differing domains — which inference rejects today, so the bullet says that rather than implying the Σ runs. Two smaller fixes ride along in the sentence being rewritten: `strict wall` becomes the strict `typecheck` pass it stands for, and `§4.6` becomes the heading citation `doc_refs` can check. `lambda_elim.rs`'s `Union domain = Variant({Index(i): …})` comment reads like the same residue and is not: that is the C-form path, which still builds a real `Copair`, so its tagged domain is still the truth.
dpmills
force-pushed
the
dmills/partition-collapse-composes
branch
from
August 18, 2026 01:15
f00629f to
4ca946a
Compare
Case fan-out's prose to the DisjointJoin it builds
Contributor
Author
|
After rebasing, this was actually made obsolete by PR 86. There was a bit of related cleanup to do, so I've done those tiny changes here |
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three prose sites still described the value-
Casefan-out as it worked before theCollectionUnionsplit (#86), reconciling a coproduct against theCase's type byis_index_partition_of— a helper #86 deleted. Two are test comments, one ismutability.md's data-typed-selection bullet; all three now state whatlambda_elim::build_value_case_fanoutbuilds, aDisjointJoinover the one domain the arms share.Σstays as the recorded design for arms at differing domains, which inference rejects today. Comments and doc prose only, no code changes.