Skip to content

Update the value-Case fan-out's prose to the DisjointJoin it builds - #75

Merged
dpmills merged 1 commit into
mainfrom
dmills/partition-collapse-composes
Aug 18, 2026
Merged

Update the value-Case fan-out's prose to the DisjointJoin it builds#75
dpmills merged 1 commit into
mainfrom
dmills/partition-collapse-composes

Conversation

@dpmills

@dpmills dpmills commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Three prose sites still described the value-Case fan-out as it worked before the CollectionUnion split (#86), reconciling a coproduct against the Case's type by is_index_partition_of — a helper #86 deleted. Two are test comments, one is mutability.md's data-typed-selection bullet; all three now state what lambda_elim::build_value_case_fanout builds, a DisjointJoin over the one domain the arms share. Σ stays as the recorded design for arms at differing domains, which inference rejects today. Comments and doc prose only, no code changes.

@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from d97ecfc to e797e30 Compare August 11, 2026 22:34
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from e797e30 to ab3b01c Compare August 12, 2026 00:09
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from ab3b01c to 87987ce Compare August 12, 2026 00:38
@dpmills
dpmills marked this pull request as ready for review August 12, 2026 03:21
@dpmills
dpmills requested a review from a team as a code owner August 12, 2026 03:21
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from 87987ce to 7d00832 Compare August 12, 2026 20:08
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from 7d00832 to eea8c58 Compare August 12, 2026 20:42
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from eea8c58 to a9d9d6d Compare August 12, 2026 22:30
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from a9d9d6d to fb63833 Compare August 12, 2026 22:45
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from fb63833 to 70e744b Compare August 13, 2026 05:39
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from 70e744b to 0e93344 Compare August 13, 2026 06:01
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from 0e93344 to 677103e Compare August 13, 2026 19:18
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from 677103e to 0a9a39d Compare August 13, 2026 23:42
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from 0a9a39d to f977425 Compare August 14, 2026 19:49
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from f977425 to c52705f Compare August 14, 2026 21:34
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from c52705f to b835b47 Compare August 14, 2026 21:41
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from b835b47 to e3f3d20 Compare August 14, 2026 23:11
@dpmills
dpmills requested a review from sortalongo August 14, 2026 23:21
Base automatically changed from dmills/dup-key-invariant to main August 17, 2026 17:57
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from e3f3d20 to f00629f Compare August 17, 2026 17:57
@dpmills dpmills changed the title Partition collapse composes: replace the bridge arm with normalize-then-recurse Make partition-domain subtyping transitive by normalizing before comparing Aug 17, 2026

@sortalongo sortalongo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a redundant-jargon pass? There are a few terms that I hadn't seen before cropping up here that I'm not sure deserve coining (grounded subtyping, gate, bridge, chain).

Comment thread src/ccl/design/type-inference.md Outdated
Comment thread src/ccl/design/type-inference.md Outdated
Splitting `CollectionUnion` into `Copair` and `DisjointJoin` (#86) deleted `is_index_partition_of` and the subtyping arm that reconciled a `Variant`-domain fan-out against a plain-domain demand. Three prose sites still describe that mechanism. They are comments, so the suite stays green while asserting requirements on code that no longer exists, and `doc_refs` cannot see them: it validates doc paths and headings, not identifiers named in comments.

`tests/compilation_pipeline/conditionals.rs` twice told the reader the fan-out's tagged-`Variant` domain reconciles against the arms' joined data function by `is_index_partition_of`, once as a requirement that function "must accept". Both now say what the fan-out builds: a `DisjointJoin` over the one domain the arms share, each leg restricted by its own gate.

`mutability.md`'s data-typed-selection bullet claimed the same collapse as one of two reconciliation paths. It now states the join landing on the shared domain, and keeps the Σ path for arms at differing domains — which inference rejects today, so the bullet says that rather than implying the Σ runs. Two smaller fixes ride along in the sentence being rewritten: `strict wall` becomes the strict `typecheck` pass it stands for, and `§4.6` becomes the heading citation `doc_refs` can check.

`lambda_elim.rs`'s `Union domain = Variant({Index(i): …})` comment reads like the same residue and is not: that is the C-form path, which still builds a real `Copair`, so its tagged domain is still the truth.
@dpmills
dpmills force-pushed the dmills/partition-collapse-composes branch from f00629f to 4ca946a Compare August 18, 2026 01:15
@dpmills dpmills changed the title Make partition-domain subtyping transitive by normalizing before comparing Update the value-Case fan-out's prose to the DisjointJoin it builds Aug 18, 2026
@dpmills

dpmills commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

After rebasing, this was actually made obsolete by PR 86. There was a bit of related cleanup to do, so I've done those tiny changes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants