Skip to content

fix: normalize iOS simulator screenshot density#1160

Merged
thymikee merged 6 commits into
mainfrom
fix/screenshot-pixel-density
Jul 8, 2026
Merged

fix: normalize iOS simulator screenshot density#1160
thymikee merged 6 commits into
mainfrom
fix/screenshot-pixel-density

Conversation

@thymikee

@thymikee thymikee commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

  • default iOS simulator screenshots now normalize to 1x logical-point density so PNG pixels match snapshot coordinates
  • added --pixel-density for explicit screenshot scaling and surfaced width/height/density metadata in responses
  • kept overlay refs aligned across density changes and added focused coverage for flag plumbing, router metadata, and simulator resizing

Validation

  • pnpm build
  • ./node_modules/.bin/tsgo -p tsconfig.json
  • node ./node_modules/oxfmt/bin/oxfmt --check src test skills package.json tsconfig.json tsconfig.lib.json tsdown.config.ts vitest.config.ts .github/actions/setup-node-pnpm/action.yml .oxlintrc.json .oxfmtrc.json '!test/skillgym/.skillgym-results/**'
  • pnpm exec vitest run src/commands/capture/screenshot-options.test.ts src/commands/capture/index.test.ts src/cli/parser/tests/args-parse-interaction.test.ts src/replay/tests/script.test.ts src/daemon/tests/response-views.test.ts src/daemon/tests/request-router-screenshot.test.ts src/cli/commands/tests/screenshot.test.ts src/tests/client.test.ts src/platforms/apple/core/tests/index.test.ts
  • node --test test/integration/smoke-*.test.ts

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.6 MB 1.6 MB +4.4 kB
JS gzip 508.6 kB 510.0 kB +1.4 kB
npm tarball 611.7 kB 613.2 kB +1.6 kB
npm unpacked 2.2 MB 2.2 MB +4.6 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.5 ms 28.1 ms +0.5 ms
CLI --help 56.0 ms 55.6 ms -0.4 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/internal/daemon.js +1.5 kB +500 B
dist/src/tv-remote.js +775 B +249 B
dist/src/apps.js +656 B +217 B
dist/src/registry.js +206 B +76 B
dist/src/runtime.js +318 B +72 B

@thymikee thymikee force-pushed the fix/screenshot-pixel-density branch from a3ad4d1 to 5eb0828 Compare July 8, 2026 16:56
@thymikee

thymikee commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Review pass on f5f1ea0: no actionable blockers found. I checked the screenshot command surface, daemon/request routing, iOS simulator capture path, overlay scaling, response metadata, and focused tests. CI is 21/21 green. Residual risk: I did not run a local simulator capture in this monitor pass; this relies on the PR's automated screenshot density/overlay coverage and green CI.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Jul 8, 2026
@thymikee thymikee removed the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Jul 8, 2026
@thymikee

thymikee commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Removed ready-for-human for now because the head moved from the reviewed f5f1ea0 to 2e528da and a Smoke Tests job is still pending. I will re-review/relabel after the updated head is stable.

@thymikee

thymikee commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Review pass on f770fc8: rechecked the incremental screenshot-density changes after the head update. The new metadata helper, PNG header reader, simulator scale cache, and malformed non-iOS PNG tolerance are covered by focused tests; checks are 21/21 green. No actionable blockers found. Residual risk remains that I did not run a local simulator capture in this monitor pass.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Jul 8, 2026
@thymikee thymikee merged commit 2717047 into main Jul 8, 2026
21 checks passed
@thymikee thymikee deleted the fix/screenshot-pixel-density branch July 8, 2026 19:05
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-08 19:05 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant