feat(p2-shim): support symlink for browser in-memory filesystem - #2057
Merged
vados-cosmonic merged 3 commits intoSep 7, 2026
Merged
Conversation
eduardomourar
requested review from
andreiltd and
vados-cosmonic
as code owners
September 6, 2026 13:41
eduardomourar
force-pushed
the
feat/p2-shim-browser-support-symlink
branch
from
September 6, 2026 13:42
1641a93 to
6e4b44c
Compare
eduardomourar
changed the title
eduardomourar
force-pushed
the
feat/p2-shim-browser-support-symlink
branch
from
September 6, 2026 14:14
6e4b44c to
3743f5c
Compare
Resolve lookups, parent paths, and creation with one bounded directory stack. Keep dangling links intact, enforce exclusive creation, allow parent-relative targets within the descriptor capability, and reject preset absolute targets. Apply legacy CWD handling only to the original lookup path. Add concurrent regression tests for creation, path boundaries, mutations, and symlink limits.
Compile one component and run its filesystem operations in the browser. Cover normal symlink behavior and the creation, relative-path, CWD, and absolute-target regressions with concurrent result assertions while sharing compilation and browser setup.
vados-cosmonic
approved these changes
Sep 7, 2026
vados-cosmonic
enabled auto-merge
September 7, 2026 02:58
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 7, 2026
Collaborator
|
🎉 The code in this PR was made available in the following release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements symlink-at/readlink-at in
InMemoryFilesystemAdapter, which previously threw "unsupported" for both. Path resolution (open-at, stat-at, set-times-at, link-at, metadata-hash-at) now follows symlinks per-segment and honors path flags.symlink-follow instead of ignoring it, with cycle detection (loop error) and directory-listing/stat type reporting updated to recognizesymbolic-linkentries.Symlink targets are always relative, resolved against the directory containing the link — this sandboxed filesystem has no host-absolute root, matching existing path-resolution and the Node backend's behavior.