fix: Map expired artifact to ErrBlobNotFound#4087
Merged
Merged
Conversation
zhming0
approved these changes
Jul 15, 2026
zhming0
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a really minor note that this is a OSS repo. Some people might audit our changes, so we should make PR description descriptive for 3rd party reader 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Map nsc's "the artifact has expired" download error to ErrBlobNotFound (alongside "not found"), so an expired HA cache entry is treated as a cache miss and invalidated instead of failing the build.
Context
https://linear.app/buildkite/issue/A-1541/namespace-artifact-expiry-breaks-ha-cache-bust-mechanism
Changes
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Affiliation (optional, external contributors)
Disclosures / Credits