Skip to content

fix: Map expired artifact to ErrBlobNotFound#4087

Merged
ss1909 merged 1 commit into
mainfrom
sneha/fix-expired-nsc-artifact
Jul 15, 2026
Merged

fix: Map expired artifact to ErrBlobNotFound#4087
ss1909 merged 1 commit into
mainfrom
sneha/fix-expired-nsc-artifact

Conversation

@ss1909

@ss1909 ss1909 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Description

Map nsc's "the artifact has expired" download error to ErrBlobNotFound (alongside "not found"), so an expired HA cache entry is treated as a cache miss and invalidated instead of failing the build.

Context

https://linear.app/buildkite/issue/A-1541/namespace-artifact-expiry-breaks-ha-cache-bust-mechanism

Changes

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go tool gofumpt -extra -w .)

Affiliation (optional, external contributors)

Disclosures / Credits

@ss1909 ss1909 requested review from a team as code owners July 15, 2026 04:23
@ss1909 ss1909 added the bug label Jul 15, 2026
@ss1909 ss1909 enabled auto-merge July 15, 2026 04:25
@ss1909 ss1909 merged commit 00f757f into main Jul 15, 2026
4 of 5 checks passed
@ss1909 ss1909 deleted the sneha/fix-expired-nsc-artifact branch July 15, 2026 04:28

@zhming0 zhming0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a really minor note that this is a OSS repo. Some people might audit our changes, so we should make PR description descriptive for 3rd party reader 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants