Skip to content

updateGitMirror: use double checked locking #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byroot wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

updateGitMirror: use double checked locking #4074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/job/checkout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,15 @@ func (e *Executor) updateGitMirror(ctx context.Context, repository string) (dir
e.shell.Commentf("Acquiring mirror repository update lock")
}

if isMainRepository {
// Check if the commit is in the mirror before acquiring the lock
// This is an operation that is safe to perform concurrently.
if hasGitCommit(ctx, e.shell, mirrorDir, e.Commit) {
e.shell.Commentf("Commit %q exists in mirror", e.Commit)
return e.snapshotMirror(ctx, repository, mirrorDir)
}
}

// Lock the mirror dir to prevent concurrent updates
updateCtx, canc := context.WithTimeout(ctx, lockTimeout)
defer canc()
Expand Down
Loading