Start SQL Integration Tests by yyforyongyu · Pull Request #1292 · btcsuite/btcwallet

yyforyongyu · 2026-07-13T06:20:10Z

Switches the default runtime store backend for newly-created wallets from kvdb
to SQLite so the integration tests exercise the SQL store by default: an unset
DBConfig.Backend now resolves to SQLite, with a default SQLite path derived
next to the legacy kvdb database. Callers opening an existing kvdb-only wallet
set Backend: DBBackendKVDB explicitly. The bwtest harness now honors its
configured backend so db=kvdb parity runs still exercise kvdb rather than
silently falling back to SQLite.

Single commit. Stacked on impl-runtime-store-6.

coveralls · 2026-07-13T06:27:53Z

Coverage Report for CI Build 29745821027

Warning

No base build found for commit f6d677d on impl-runtime-store-6.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 57.437%

Details

Patch coverage: 32 uncovered changes across 1 file (5 of 37 lines covered, 13.51%).

Uncovered Changes

File	Changed	Covered	%
bwtest/harness_wallet.go	32	0	0.0%
Total (3 files)	37	5	13.51%

Coverage Regressions

Requires a base build to compare against. How to fix this →

Coverage Stats


Relevant Lines:	62367
Covered Lines:	35822
Line Coverage:	57.44%
Coverage Strength:	11998.11 hits per line

💛 - Coveralls

yyforyongyu · 2026-07-17T08:30:13Z

No issues found by glm-5.2 🎲

yyforyongyu · 2026-07-18T11:39:10Z

No issues found by gpt-5.5 🪄

yyforyongyu · 2026-07-18T11:40:15Z

No issues found by k3 🎈

yyforyongyu · 2026-07-18T11:40:26Z

No issues found by glm-5.2 on re-review of the updated PR. 🌻

yyforyongyu · 2026-07-19T10:28:12Z

No issues found by glm-5.2 on re-review of the updated PR. 🍀

yyforyongyu · 2026-07-20T11:28:52Z

No issues found by k3 🎯

yyforyongyu · 2026-07-20T11:34:48Z

No issues found by glm-5.2 on re-review of the updated PR. ❇️

yyforyongyu · 2026-07-20T11:47:28Z

No issues found by gpt-5.5 🪁

yyforyongyu · 2026-07-21T10:07:40Z

No issues found by glm-5.2 on re-review of the updated PR. 🎆

yyforyongyu · 2026-07-21T10:09:13Z

No issues found by k3 🍀

yyforyongyu · 2026-07-21T10:12:59Z

No issues found by gpt-5.5 🧵

yyforyongyu · 2026-07-23T12:37:15Z

+// backend is SQLite and no SQLite path was given, a deterministic default is
+// derived next to the legacy kvdb database (DB.KVDB.DBPath) so the runtime
+// store has a stable on-disk location.
+func (c DBConfig) withDefaults() DBConfig {


This PR is still based on the pre-restructure impl-runtime-store-6: its head (63691af) is not an ancestor of the new stack, GitHub reports CONFLICTING, and the PR diff currently shows the entire old 27-commit stack underneath its own 2 commits; rebase onto the new impl-runtime-store-6 (950e3de) so the diff shrinks back to the two sqlite-default commits. k3

yyforyongyu · 2026-07-23T12:37:20Z

No issues found by glm-5.2 on re-review of the updated PR. :choo_choo:

yyforyongyu · 2026-07-23T12:41:31Z

+		// The account is absent. On an already created wallet this is an
+		// over-create adding a new account, not a partial-import retry to
+		// complete, so reject it instead of mutating the wallet.
+		if preCreated {


This reintroduces the partial-create wedge that the base fixed: when an earlier attempt created the wallet row and imported only a prefix of InitialAccounts, retry sets preCreated and rejects the first missing account instead of completing it; keep the durable create_complete marker and only reject wallets marked complete. (gpt-5.5)

Flip the zero-value store Backend from DBBackendKVDB to DBBackendSQLite, so new library-created wallets default to the SQLite runtime store. Callers opening an existing kvdb-only wallet must now set DBBackendKVDB explicitly to keep using walletdb.

Default the integration-test backend to SQLite and wire the harness to resolve the configured backend: kvdb and SQLite both run off the subtest DB path, while postgres is rejected with a clear message since the harness provisions no DSN. Update the Makefile default and ADR 0008 to match.

yyforyongyu · 2026-07-23T20:02:59Z

No issues found by glm-5.2 on re-review of the updated PR. 🧭

yyforyongyu · 2026-07-23T20:07:12Z

No issues found by k3 🌊

saubyk assigned yyforyongyu Jul 13, 2026

saubyk added this to lnd v0.22 Jul 13, 2026

github-project-automation Bot moved this to Backlog in lnd v0.22 Jul 13, 2026

yyforyongyu force-pushed the impl-runtime-store-6 branch from 16e8413 to b23830b Compare July 13, 2026 06:41

yyforyongyu force-pushed the wallet-default-sqlite branch from 8e55040 to 1f88969 Compare July 13, 2026 06:41

yyforyongyu commented Jul 13, 2026

View reviewed changes

Comment thread bwtest/harness_wallet.go Outdated

yyforyongyu commented Jul 13, 2026

View reviewed changes

Comment thread bwtest/harness_wallet.go Outdated

yyforyongyu commented Jul 13, 2026

View reviewed changes

Comment thread wallet/runtime_store_config.go

yyforyongyu commented Jul 13, 2026

View reviewed changes

Comment thread wallet/signer_test.go Outdated

yyforyongyu mentioned this pull request Jul 13, 2026

wallet+db: add GetAccountSecret Store surface and keyvault routing #1272

Draft

yyforyongyu commented Jul 13, 2026

View reviewed changes

Comment thread wallet/runtime_store_config.go

yyforyongyu force-pushed the impl-runtime-store-6 branch from b23830b to ecb2ba3 Compare July 14, 2026 13:46

yyforyongyu force-pushed the wallet-default-sqlite branch from 1f88969 to d011a90 Compare July 14, 2026 13:46

yyforyongyu force-pushed the impl-runtime-store-6 branch from ecb2ba3 to 7341df7 Compare July 14, 2026 18:03

yyforyongyu force-pushed the wallet-default-sqlite branch from d011a90 to 8758c4f Compare July 14, 2026 18:03