Fix line plot labels#1893
Open
blerner wants to merge 2 commits into
Open
Conversation
added 2 commits
July 17, 2026 12:33
…g dots to hover over. We agreed that the visual behavior should be visually equivalent to render-charts([list: line-plot, labeled-scatter-plot]) -- i.e., the dots should always be visible, and therefore always hoverable. This is different behavior than GCharts had (where the dots were invisible). I'm handling this by making the pointsize be optional; the point-size method and the labels method both set it to some() value, so that having labels implies having visible points.
…library annotations do this for us already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would almost work, except that it would create two plots and therefore affect the legend. It also means that
line-plot().labels()was also broken and should be fixed.This PR fixes labels to work properly by ensuring that the dots will be visible. It also cleans up some redundant list-element checks (that our chart-utils annotations already check for us)