Skip to content

Be more explicit in the way we declare deferred data - #63

Open
andresgutgon wants to merge 1 commit into
brocoders:v1from
andresgutgon:feature/deferred-first-class-citizen
Open

Be more explicit in the way we declare deferred data#63
andresgutgon wants to merge 1 commit into
brocoders:v1from
andresgutgon:feature/deferred-first-class-citizen

Conversation

@andresgutgon

Copy link
Copy Markdown

What?

Dealing with deferred data is not working as expected for me. I've moved the code of this lib to my project and I've been playing with it to see how it works.

These are the changes necessary to make deferred works for me.

What I mean with deferred?

I've see somewhere in the issues of this repo or in documentation that you can avoid fetching some of your data on the server with a filter like this:

In your component @asyncConect put the flag deferred:

@asyncConnect([{
  deferred: true,
  promise: (options) => {
    return options.store.dispatch(loadDeferredThing(options.params.id));
  },
}])

And then in your client.js or server.js filter items that are not deferred:

filter: (item) => !item.deferred,

☝️ that way is not working for me.

What I'm doing here?

With this changes you do not need to filter anything on server or client. You just need to declare the promise as deferred in your component and the lib take care of it.

This is working for me. The code can be improved but I just wanted to show you my idea.

@andresgutgon
andresgutgon force-pushed the feature/deferred-first-class-citizen branch from ab02c49 to 3a0c4c2 Compare March 13, 2016 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant