Be more explicit in the way we declare deferred data - #63
Open
andresgutgon wants to merge 1 commit into
Open
Conversation
andresgutgon
force-pushed
the
feature/deferred-first-class-citizen
branch
from
March 13, 2016 18:07
ab02c49 to
3a0c4c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Dealing with deferred data is not working as expected for me. I've moved the code of this lib to my project and I've been playing with it to see how it works.
These are the changes necessary to make deferred works for me.
What I mean with deferred?
I've see somewhere in the issues of this repo or in documentation that you can avoid fetching some of your data on the server with a filter like this:
In your component @asyncConect put the flag
deferred:And then in your
client.jsorserver.jsfilter items that are not deferred:☝️ that way is not working for me.
What I'm doing here?
With this changes you do not need to filter anything on server or client. You just need to declare the promise as
deferredin your component and the lib take care of it.This is working for me. The code can be improved but I just wanted to show you my idea.