Repository navigation
Conversation
talazuri
requested a deployment
to
scan-security
October 11, 2026 08:10 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
eshmayovitz
requested a deployment
to
scan-security
October 11, 2026 08:58 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
eshmayovitz
requested a deployment
to
scan-security
October 11, 2026 09:34 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
maxamel
reviewed
Oct 12, 2026
| self._set_connected_node(destination_attributes, origin_attributes) | ||
| continue | ||
| if origin_attributes.get(CustomAttributes.BLOCK_TYPE) == BlockType.OUTPUT: | ||
| print(1) |
maxamel
reviewed
Oct 12, 2026
| if node.get(CustomAttributes.RESOURCE_TYPE) in connected_type_set: | ||
| file_path = node.get(CustomAttributes.FILE_PATH, "") | ||
| vals = connected_values_by_file.setdefault(file_path, set()) | ||
| for val in node.values(): |
Contributor
There was a problem hiding this comment.
This iteration matches by string, is there a risk of FPs here? We can have similar name nodes in different places.
maxamel
reviewed
Oct 12, 2026
| except StopIteration: | ||
| continue | ||
|
|
||
| def _value_based_fallback( |
Contributor
There was a problem hiding this comment.
what is the performance impact of this function? I see lots of node iterations and for large graphs it could have a real impact
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: