refactor(partner): wave1/2 hard-cut capacity dual-read and dead aliases - #55
Merged
Merged
Conversation
Delete skin-account-guard facade; drop deprecated sport-binding aliases and bookOffersSkin; capacity reads meta.liveProducts only (ignore meta.skins/defaultSkin/skin column); TOML live_products only; rename desk_snapshot skinCount→productCount; migrate fixtures/docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 1 + Wave 2 cleanup after the #47–#54 rename series:
skin-account-guard.tsfacadeSKIN_SPORT_BINDINGS,listSkinSportBindings,skinHasSportCoverage,skinsWithBindings,DEFAULT_COVERAGE_SKIN,SkinSportBinding,bookOffersSkin)meta.liveProductsonly — ignore legacymeta.skins/defaultSkin/betting_accounts.skinlive_productsonly (legacyskins =ignored)skinCount→productCountClaim → evidence
bun run check— 1497 passout-identity+toml-configtests assert skins ignoredledger.writeDeskSnapshot+ finance-cron + risk-health testTest plan
Operator note
Any remaining TOML with
skins =must move tolive_products =before seed (capacity will otherwise fall back to wire"2"at $0).Local merge proof
Commit
f5aef18— pre-commit ok